Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): fix floating point decimal precision #750

Merged
merged 8 commits into from
Aug 2, 2021
Merged

fix(slider): fix floating point decimal precision #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4c22738
fix(slider): fix floating point decimal precision
fengT-T Aug 1, 2021
5a051a6
Update src/slider/src/Slider.tsx
fengT-T Aug 2, 2021
9838629
Update src/slider/src/Slider.tsx
fengT-T Aug 2, 2021
974362d
Update src/slider/src/Slider.tsx
fengT-T Aug 2, 2021
76eed62
fix(slider): fix floating point decimal precision
fengT-T Aug 2, 2021
a2837b0
fix(slider): update changelog
fengT-T Aug 2, 2021
0479a2f
Update CHANGELOG.en-US.md
fengT-T Aug 2, 2021
da4807b
Update CHANGELOG.zh-CN.md
fengT-T Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.en-US.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# CHANGELOG

## Pending

### Feats

### Fixes

- Fix `n-slider` loss floating point decimal precision, closes [#751](https://github.com/TuSimple/naive-ui/issues/751).

## 2.16.0 (2021-08-02)

### Breaking Changes
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# CHANGELOG

## Pending

### Feats

### Fixes

- 修复 `n-slider` 丢失浮点数小数精度，关闭 [#751](https://github.com/TuSimple/naive-ui/issues/751)

## 2.16.0 (2021-08-02)

### Breaking Changes
Expand Down
8 changes: 8 additions & 0 deletions src/slider/src/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,13 @@ export default defineComponent({
const railRef = ref<HTMLElement | null>(null)
const followerRef1 = ref<FollowerInst | null>(null)
const followerRef2 = ref<FollowerInst | null>(null)
const precisionRef = computed(() => {
const precisions = [props.min, props.max, props.step].map((item) => {
const fraction = String(item).split('.')[1]
return fraction ? fraction.length : 0
})
return Math.max(...precisions)
})

const uncontrolledValueRef = ref(props.defaultValue)
const controlledValueRef = toRef(props, 'value')
Expand Down Expand Up @@ -459,6 +466,7 @@ export default defineComponent({
justifiedValue = Math.max(min, justifiedValue)
justifiedValue = Math.min(max, justifiedValue)
justifiedValue = Math.round((justifiedValue - min) / step) * step + min
justifiedValue = parseFloat(justifiedValue.toFixed(precisionRef.value))
if (marks) {
const closestMarkValue = getClosestMarkValue(value)
if (
Expand Down