[desktop/linux] fix & upgrade keytar

[ganthern]

Stock keytar doesn't tell us whether getPassword can't return a password due to user cancellation or because there's no password saved.

https://github.com/tutao/node-keytar makes that distinction visible on linux

Testing

On Linux specifically:

• starting tutanota desktop with an unlocked login keychain works as expected and sseInfo, notifications and alarms get loaded (install seahorse to check the keychain)
• starting tutanota desktop with a locked login keychain will prompt for the password and
  • cancelling shows an error dialog that the keychain is unavailable
  • unlocking the keychain causes startup to proceed normally

[evilrobot-01]

Will this build on arm64? I believe the existing keytar was one of the blockers for getting Tutanota running on arm64 Linux, so would be great if this was solved. 🙏

[charlag]

@EVLRBT-01 it's not a blocker anymore since we build keytar on our own anyway. We just don't provide ARM builds yet, for either Linux or Mac. Someone could just do it (like AUR does probably?)

[evilrobot-01]

Excellent, will give it a go, thanks!

…

________________________________ From: Ivan Kupalov ***@***.***> Sent: Monday, January 24, 2022 8:02:50 AM To: tutao/tutanota ***@***.***> Cc: EVLRBT-01 ***@***.***>; Mention ***@***.***> Subject: Re: [tutao/tutanota] [desktop/linux] fix & upgrade keytar (Issue #3809) @EVLRBT-01<https://github.com/EVLRBT-01> it's not a blocker anymore since we build keytar on our own anyway. We just don't provide ARM builds yet, for either Linux or Mac. Someone could just do it (like AUR does probably?) — Reply to this email directly, view it on GitHub<#3809 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AORABCWHS5Y5XS3BDMP6HMDUXUBSVANCNFSM5MGJ6CHA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[evilrobot-01]

I was able to get an arm64 build based on https://github.com/tutao/tutanota/blob/master/doc/BUILDING.md#building-and-running-your-own-tutanota-desktop-client and a few changes to buildSrc/electron-package-json-template.js, based on #3020

diff --git a/buildSrc/electron-package-json-template.js b/buildSrc/electron-package-json-template.js
index 8d57ead03..a1f547340 100644
--- a/buildSrc/electron-package-json-template.js
+++ b/buildSrc/electron-package-json-template.js
@@ -81,7 +81,7 @@ export default function generateTemplate({nameSuffix, version, updateUrl, iconPa
                        "productName": nameSuffix.length > 0
                                ? nameSuffix.slice(1) + " Tutanota Desktop"
                                : "Tutanota Desktop",
-                       "artifactName": "${name}-${os}.${ext}",
+                       "artifactName": "${name}-${os}-${arch}.${ext}",
                        "afterSign": notarize ? "buildSrc/notarize.cjs" : undefined,
                        "protocols": [
                                {
@@ -125,7 +125,7 @@ export default function generateTemplate({nameSuffix, version, updateUrl, iconPa
                                "target": [
                                        {
                                                "target": unpacked ? "dir" : "nsis",
-                                               "arch": "x64"
+                                               "arch": ["x64", "arm64"]
                                        }
                                ]
                        },
@@ -171,7 +171,7 @@ export default function generateTemplate({nameSuffix, version, updateUrl, iconPa
                                "target": [
                                        {
                                                "target": unpacked ? "dir" : "AppImage",
-                                               "arch": "x64"
+                                               "arch": ["x64", "arm64"]
                                        }
                                ]
                        }

[charlag]

I couldn't get it to work yet. Here's what I did:

• run gnome-keyring-daemon -f -r to effectively "lock" the keychain
• Start the app
• See keyring prompt, cancel it
• See another keyring prompt, cancel it
• client shows "could not access secret storage" dialog, see from output that client treats it like cancellation (like it should)
• try to select stored credentials
• See 2 other prompts and cancel them
• client output "key credentials-device-lock-key not found, generating a new one" which shouldn't actually happen. Also 2 error dialogs (native and in app)

[charlag]

This is actually more of a #3733 so I will move it there