Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to keytar@7.6.0 and build arm binaries. #3020

Closed
wants to merge 1 commit into from

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented May 6, 2021

Adds support for building binaries that will run on arm64/aarch64 devices.

Warning

I have only tested the arm builds on my PinePhone (Linux) and can vouch it works well.
I have no way, or at least don't know of a way, to test the Windows or macOS builds.

Changes

arm64 Binaries

Adds the arm64 arch to all build targets.
This also requires renaming artifacts to tutanota-os-arch.ext, this avoids arch builds from overwriting the previous.

Upgrading keytar

keytar 7.4.0 adds Linux arm64 prebuilt binaries. atom/node-keytar#352

This upgrades keytar to 7.6.0, this is not the latest version.
keytar 7.7.0 (latest) moves to using NAPI prebuilds (atom/node-keytar#331), however electron-builder is being a pain with fetching those binaries.

There is a workaround for this, but I figured for now it'd be simpler to stick with the latest non NAPI release, and shift over later once electron-builder handles that case better.
atom/node-keytar#380

.gitignore dist

Was there a reason this wasn't there before?

Related Issues

@charlag
Copy link
Contributor

charlag commented May 6, 2021

Hey
Thanks a lot for the PR!

We are actually switching to building keytar on our own, do you think we can cross-compile easily? There's PR for that #3016

@SethFalco
Copy link
Contributor Author

SethFalco commented May 6, 2021

do you think we can cross-compile easily

I've never dealt with native dependencies or cross-compiling architectures before, unfortunately. ^-^'

It's certainly possible, that's what keytar themselves are doing. atom/node-keytar#352
I don't know if it's "easy" in this case, though.

I can explore the referenced PR later; we'll see with that branch if I can get the build working on my PinePhone.

@charlag
Copy link
Contributor

charlag commented May 7, 2021

@SethFalco thanks! We will first finish up building keytar and can look into ARM after that

@ark- ark- mentioned this pull request Jun 14, 2021
7 tasks
@ark-
Copy link

ark- commented Jun 19, 2021

Now that #3016 is closed is ARM support something that's being considered?

@charlag
Copy link
Contributor

charlag commented Jun 21, 2021

It would take some work to cross-compile things so we would appreciate help with that

@charlag
Copy link
Contributor

charlag commented Dec 20, 2021

Hi
We will be dropping Keytar anyway and we will revisit ARM builds later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[desktop] offer an ARM target Support Apple M1 devices
3 participants