Upgrade to keytar@7.6.0 and build arm binaries. #3020
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for building binaries that will run on arm64/aarch64 devices.
Warning
I have only tested the arm builds on my PinePhone (Linux) and can vouch it works well.
I have no way, or at least don't know of a way, to test the Windows or macOS builds.
Changes
arm64 Binaries
Adds the
arm64
arch to all build targets.This also requires renaming artifacts to
tutanota-os-arch.ext
, this avoids arch builds from overwriting the previous.Upgrading keytar
keytar 7.4.0 adds Linux arm64 prebuilt binaries. atom/node-keytar#352
This upgrades keytar to 7.6.0, this is not the latest version.
keytar 7.7.0 (latest) moves to using NAPI prebuilds (atom/node-keytar#331), however electron-builder is being a pain with fetching those binaries.
There is a workaround for this, but I figured for now it'd be simpler to stick with the latest non NAPI release, and shift over later once electron-builder handles that case better.
atom/node-keytar#380
.gitignore dist
Was there a reason this wasn't there before?
Related Issues