Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple M1 devices #2625

Closed
7 tasks done
ark- opened this issue Jan 16, 2021 · 29 comments · Fixed by #6185
Closed
7 tasks done

Support Apple M1 devices #2625

ark- opened this issue Jan 16, 2021 · 29 comments · Fixed by #6185
Labels
desktop Desktop client related issues improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Milestone

Comments

@ark-
Copy link

ark- commented Jan 16, 2021

As a user of desktop mac application i want to have support for arm architecture so i don't have to enable legacy support for my applie silicon mac.

AC

  • User can use the desktop application without rosetta
  • Intel macs are still supported
  • There is one binary which supports both architectures.

Tasks

  • Test whether running node desktop -a universal builds a universal binary on Mac
  • Adjust Jenkins job to build a universal binary on M1 mac
  • Try merge option
  • Test whether the desktop client runs on older versions of macOS (BigSur & Monterey)

Notes

  • We might need to setup the build environment on the new mac if we cannot build apple silicon binaries on the old one.

  • We need to include arm precompiled binaries for openssl/sql cipher.

Notes (issue reported by user)

Describe the bug
There is no arm64 binary available for Apple M1 devices. Currently the app needs to be run through Rosetta translation. This is important as all Apple desktop/laptop devices will be using this chip going forward and they claim it's as easy as adding an additional target in the build process.

To Reproduce
NA

Expected behavior
Native binary available for Apple Silicon (currently only M1).

Screenshots
2021-01-16 at 10 20

Desktop (please complete the following information):

  • OS: MacOS
  • Version: 3.80.4

Additional context
http://doesitarm.com shows a bunch of apps which have already implemented native support.

Test Notes

  • the dmg does work on MacOS
    • on the M1 chip
    • also for intel
  • linux desktop client starts
  • on all desktop platform, it's possible to use previously stored credentials to log in
@ark- ark- added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Jan 16, 2021
@thinkofher
Copy link

Being able to use tutanota as native application for M1 based macs would be terrific. Especially because, as far as I know, electron already supports M1.

Is building tutanota for M1 something more than digging in CI?

@ark-
Copy link
Author

ark- commented Jun 14, 2021

Hi all.

The ARM binaries were previously held up by Tutanota building keytar themselves. That PR is merged now: #3016

Is there a plan to continue with #3020? I'm noticing a few bugs with my M1 mac and wanted to wait for the ARM64 release before reporting them all.

@johnbotris
Copy link
Contributor

Once we change to use safeStorage and drop keytar (#3676), will we then get this for free?

@charlag
Copy link
Contributor

charlag commented Nov 29, 2021

@johnbotris still need to build for it

@evilrobot-01
Copy link

+1 for arm64 support, for general Linux also!

@RyanRoberts
Copy link

Another +1 for M1 support. The current Intel app is very slow to start (not a big issue).

@francocalvo
Copy link

+1 For this too! I'm using the browser till we get a native app. Thanks!

@streetcoder-pm
Copy link

Please consider arm64 on Raspberry Pi too. Meanwhile I have to use the web client as long as it is supported. Please don't stop the web client support before there is a arm64 solution for the Raspberry Pi OS (Debian arm64 based). Possible solution could be similar to the Mac M1...

@Universal-Igloo
Copy link

+1 Please prioritize this, it would make my premium subscription much more useful!

@ark-
Copy link
Author

ark- commented Mar 30, 2022

Once we change to use safeStorage and drop keytar (#3676), will we then get this for free?

safeStorage seems to be implemented now, or at least the referenced issue is closed. Is there anything else now that would prevent a arm64 build?

@charlag
Copy link
Contributor

charlag commented Apr 4, 2022

We do not use safeStorage as it is tied very tightly to how Chromium works and doesn't cover all our cases.
I don't think there are strictly technical reasons now. Just needs a lot of time investment and we are trying to push other things towards completion (e.g. offline)

@ark-
Copy link
Author

ark- commented Apr 5, 2022

My bad, I assumed it would be a quick win.

@ark-
Copy link
Author

ark- commented Jul 15, 2022

For watchers of this issue, seems to be activity over on vladimiry/ElectronMail#357

@ylluminate
Copy link

ylluminate commented Jul 16, 2022

For watchers of this issue, seems to be activity over on vladimiry/ElectronMail#357

Achieved resolution on the ElectronMail front. Works great.

@ark-
Copy link
Author

ark- commented Jul 18, 2022

Reports show that it's making a massive difference to ElectronMail users. I'm fairly frustrated by the slow start up times and having to force close and reopen Tutanota every time I put my mac to sleep.

@Universal-Igloo
Copy link

@charlag Any update on this from your end? Or an expected timeline?

Thank you for all the great work you do!

@ganthern ganthern removed their assignment Aug 4, 2022
@eriktiekstra
Copy link

@charlag any update on Apple Silicon support?
It is basically the only application I have which still lacks support.

@jactmp
Copy link

jactmp commented Mar 24, 2023

@charlag any update on Apple Silicon support?
It is basically the only application I have which still lacks support.

It is the only application I need which still lacks ARM64 support. I'm currently using web interface and am going to wait for arm version.

@JanWorks
Copy link

Really, Tutatnota is the very last application on my M1/M2 Macs without ARM64 (aka Apple Silicon) native support, using browser-based app as a stand-in in the meantime.

Frankly, I refuse to use Rosetta for several security and performance reasons. In a way it is a temporary solution, a translation layer adding attack surface (and potential bugs) and so is in direct conflict with the security-first approach of Tutanota. On a different note, it is like dragging a diesel generator trailer behind an electric car as there are no chargers anywhere near enough.

@JanWorks
Copy link

JanWorks commented Jun 8, 2023

Another month, no change, no Apple Silicon support. Tutanota is REALLY the last of my apps not having M-Series native support.

With the recent hike in pricing, any news on this front, please?

@thinkofher
Copy link

Hard to believe that I commented here more than 2 years ago. To be honest: I am not using tutanota as native app anymore on my Mac, because of lack of support for apple silicon.

@doczipeter
Copy link

This is something I'm looking forward to.

@JanWorks
Copy link

JanWorks commented Aug 7, 2023

So, yet another 2 months passed. Still no M-Series Mac (macOS) app available. Frankly, this seems to be either complete ignorance or outright intention to single-out M-Series Mac users.

BTW: boasting about PQ-crypto project is fine, even getting money from the German state (!) for this purpose might be O.K., but full omission of M-Series Macs is beyond comprehension, sorry.

@charlag
Copy link
Contributor

charlag commented Aug 7, 2023

I promise we didn't forget about new macs, sorry that it takes so long

@arcc1845
Copy link

arcc1845 commented Oct 31, 2023

The M3 was announced yesterday, but there's nothing on Tutanota about support. I think you guys forgot about the new macs.

@doczipeter
Copy link

@arcc1845 I use Tutanota as a Safari Web App now. Give it a try, maybe you'll like it.

@JanWorks
Copy link

@doczipeter I am sorry to write that web app is not a native app, hope you understand.

Once again: a NATIVE APP, if written according to secure coding practices (and, also, not using something like TypeScript or similar BS) is inherently more secure than a web app, which drags in all potential security bugs of the underlying browser.

Real secure native apps for iOS/macOS would use something like Rust and/or Swift and/or C/C++/ObjC or alike.

Tutanota is a complete ignorant in this respect. And, again, I am sorry for that.

@arcc1845
Copy link

arcc1845 commented Nov 9, 2023

I found a surprising post on Reddit today: post

And the Tutanota team says:

"Thank you for your feedback. I'll pass this on to the development team, but we definitely need to work on the import feature first."

Wow! They really were forgetting about us!

@bedhub bedhub added improvement nice-to-haves that are not impeding usage of any features and removed bug broken functionality, usability problems, unexpected errors labels Nov 20, 2023
@bedhub bedhub changed the title No Apple Silicon Support for Apple M1 devices Support Apple M1 devices Nov 20, 2023
bedhub pushed a commit that referenced this issue Nov 21, 2023
Updated electron-builder and its dependencies.
#2625
@ganthern ganthern added this to the 3.119.0 milestone Nov 27, 2023
ganthern pushed a commit that referenced this issue Nov 27, 2023
Updated electron-builder and its dependencies.
#2625
murilopereirame pushed a commit that referenced this issue Nov 27, 2023
Updated electron-builder and its dependencies.
#2625
murilopereirame pushed a commit that referenced this issue Nov 27, 2023
Updated electron-builder and its dependencies.
#2625
@murilopereirame murilopereirame added the state:done meets our definition of done label Nov 27, 2023
@murilopereirame murilopereirame self-assigned this Nov 28, 2023
@ganthern ganthern added state:tested We tested it and are about to release it and removed state:done meets our definition of done labels Dec 1, 2023
@markrossington
Copy link

Just tested the Universal binary build and it's very snappy. Much better.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Desktop client related issues improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Projects
None yet