Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build keytar on our own #3016

Merged
merged 8 commits into from
May 25, 2021
Merged

Build keytar on our own #3016

merged 8 commits into from
May 25, 2021

Conversation

rosso-ptg
Copy link

@rosso-ptg rosso-ptg commented May 4, 2021

Make sure to also run each built artifact. If something is wrong with keytar, there should be an error message right on startup of the app.

closes #2582

@rosso-ptg rosso-ptg requested a review from charlag May 4, 2021 12:18
buildSrc/DesktopBuilder.js Show resolved Hide resolved
buildSrc/DesktopBuilder.js Outdated Show resolved Hide resolved
buildSrc/compileKeytar.js Outdated Show resolved Hide resolved
buildSrc/compileKeytar.js Show resolved Hide resolved
@charlag charlag changed the title 2582 build keytar on our own Build keytar on our own May 6, 2021
@rosso-ptg rosso-ptg force-pushed the 2582-build-keytar-on-our-own branch 2 times, most recently from b727c72 to 0ed26e4 Compare May 7, 2021 09:45
@rosso-ptg rosso-ptg force-pushed the 2582-build-keytar-on-our-own branch 14 times, most recently from 22b332b to 795ff55 Compare May 18, 2021 13:10
@rosso-ptg rosso-ptg force-pushed the 2582-build-keytar-on-our-own branch from 795ff55 to d8fc9d5 Compare May 25, 2021 10:45
@mpfau mpfau merged commit 0ed36f2 into master May 25, 2021
@mpfau mpfau deleted the 2582-build-keytar-on-our-own branch May 25, 2021 11:47
@ark- ark- mentioned this pull request Jun 14, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build keytar on our own
3 participants