Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a mail from the notification does not highlight mail in list #7585

Closed
4 of 6 tasks
wrdhub opened this issue Sep 18, 2024 · 1 comment · Fixed by #7792
Closed
4 of 6 tasks

Opening a mail from the notification does not highlight mail in list #7585

wrdhub opened this issue Sep 18, 2024 · 1 comment · Fixed by #7792
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:tested-with-comments Issue has been tested but some issues were found and needs review.
Milestone
251.241108.0

Comments

@wrdhub
Copy link
Contributor

wrdhub commented Sep 18, 2024 •
edited by charlag
Loading

Describe the bug
When clicking on a notification, it opens the relevant mail. This mail is not highlighted in the mail list, so if I click on that mail (the mail that is open and should be highlighted) it reopens the mail I had previously opened.

To Reproduce
Steps to reproduce the behavior:

  1. Have desktop client open and have a mail selected (mail 1).
  2. Get a notification for a new mail (mail 2) and click on it.
  3. It goes to the desktop client and opens mail 2.
  4. Mail 2 is not highlighted in the mail list. <- First Issue
  5. Click on mail 2 in the mail list, mail 1 is opened. <- Second issue
  6. If a mail other than mail 2 is clicked, that mail is opened as normal.

Expected behavior
When the mail is opened, it should be highlighted in the mail list.

Test notes

  • Log in on desktop and make sure notifications are enabled
    • Receive an email while viewing the Inbox and click on the notification. The email should now be visibly selected in the inbox.
    • Receive an email while viewing the Archive folder and click on the notification. The email should be visible, but you are still in the Archive folder and nothing is selected.
  • On mobile, if not logged in and a notification is selected, the following behavior is true:
    • Your inbox is loaded (no missing list) with no items selected
    • The mail preview still shows the mail
@wrdhub wrdhub added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Sep 18, 2024
@wrdhub wrdhub self-assigned this Sep 19, 2024
@charlag
Copy link
Contributor

charlag commented Sep 30, 2024

This works as intended for now as email preview is detached from the list. We should discuss it again.

@paw-hub paw-hub self-assigned this Oct 18, 2024
paw-hub added a commit that referenced this issue Oct 22, 2024
@paw-hub
Try to select sticky mail if in list
aeba079 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
paw-hub added a commit that referenced this issue Oct 22, 2024
@paw-hub
Try to select sticky mail if in list
7805be3 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
@paw-hub paw-hub mentioned this issue Oct 22, 2024
Merged
paw-hub added a commit that referenced this issue Oct 22, 2024
@paw-hub
Try to select sticky mail if in list
50c2f7f 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
paw-hub added a commit that referenced this issue Oct 22, 2024
@paw-hub
Try to select sticky mail if in list
f878653 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
paw-hub added a commit that referenced this issue Oct 22, 2024
@paw-hub
Try to select sticky mail if in list
75647a0 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
@wrdhub wrdhub linked a pull request Oct 23, 2024 that will close this issue
Try to select sticky mail if in list #7792
Merged
paw-hub added a commit that referenced this issue Nov 5, 2024
@paw-hub
Try to select sticky mail if in list
36eaecd 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
paw-hub added a commit that referenced this issue Nov 6, 2024
@paw-hub
Try to select sticky mail if in list
5be1b32 
Fix the sticky mail selection behavior so that if we are on the list, it
will visually show that mail being selected. If not, don't try to go to
that list.

Fixes #7585
@wrdhub wrdhub added this to the Next client release milestone Nov 6, 2024
@wrdhub wrdhub closed this as completed in 0da5553 Nov 6, 2024
@charlag charlag self-assigned this Nov 7, 2024
@charlag charlag mentioned this issue Nov 7, 2024
Closed
7 tasks
@charlag charlag added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:tested-with-comments Issue has been tested but some issues were found and needs review.
Projects
None yet
Milestone
251.241108.0
Development

Successfully merging a pull request may close this issue.

Try to select sticky mail if in list tutao/tutanota
3 participants
@charlag @paw-hub @wrdhub