Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression when opening moved mail from notifications #7897

Closed
1 of 7 tasks
charlag opened this issue Nov 7, 2024 · 1 comment · Fixed by #7903
Closed
1 of 7 tasks

Regression when opening moved mail from notifications #7897

charlag opened this issue Nov 7, 2024 · 1 comment · Fixed by #7903
Assignees
@charlag @paw-hub
Labels
dev bug unpublished bugs, found during our development/test cycle (excluded from release notes)
Milestone
251.241108.0

Comments

@charlag
Copy link
Contributor

charlag commented Nov 7, 2024 •
edited
Loading

related to #7585

  1. Receive an email and notification while the app is suspended/not running
  2. Move that email to another folder
  3. Tap the notification to open the email
  4. See that email will be shown briefly and then closed, this matches old behavior, but the message that the email was moved is lost now

Test notes

  • Verify that the moved mail message is correctly shown when MailSets are not enabled (fixes the regression)
  • Verify that the moved mail message is correctly shown when MailSets are enabled (did not originally support MailSets but does now)
  • On a user with MailSets enabled:
    • Receive an email while logged in and receive a notification for this received email.
    • On another client, move the email.
    • Then tap the notification.
    • Verify the mail is shown with no moved mail message.
      • Note: If the mail isn't visible in the list, there won't be any mail selected despite it being open - this is correct behavior.
@charlag charlag added the dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) label Nov 7, 2024
@charlag charlag added this to the 251.241106.0 milestone Nov 7, 2024
paw-hub added a commit that referenced this issue Nov 8, 2024
@paw-hub
Check if mail moved after loading cached
67c1762 
First we check if we can re-load the Mail.

Second, we check if the mail's sets no longer contain the same folder as
the cached mail, as the mail will still disappear from view even if the
mail still exists with that ID.

This fixes a regression caused by a previous commit.

Fixes #7897
@paw-hub paw-hub mentioned this issue Nov 8, 2024
Merged
@paw-hub paw-hub closed this as completed in 5c50797 Nov 8, 2024
@charlag
Copy link
Contributor Author

charlag commented Nov 11, 2024

It works everywhere except for desktop with mail sets where it doesn't show a message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

@paw-hub paw-hub

Labels
dev bug unpublished bugs, found during our development/test cycle (excluded from release notes)
Projects
None yet
Milestone
251.241108.0
Development

Successfully merging a pull request may close this issue.

Check if mail moved after loading cached tutao/tutanota
2 participants
@charlag @paw-hub