Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repeating calendar event updates with new excluded occurrences don't get properly sent to attendees #8416

Open
ganthern opened this issue Jan 28, 2025 · 0 comments · May be fixed by #8419
Open
Assignees
Labels
bug broken functionality, usability problems, unexpected errors topic: calendar

Comments

@ganthern
Copy link
Contributor

ganthern commented Jan 28, 2025

Bug in web app

Describe the bug
repeating event updates where the organizer cancels an occurrence don't get propagated to invitees.

To Reproduce
steps to reproduce the behavior:

  1. create a weekly repeating event with account O with an attendee A
  2. accept the invite on account A
  3. delete a single occurrence on account O, make sure the update gets sent
  4. see that the update is applied on account A, but the deleted occurrence is still there. the ICS file also doesn't include the exclusion.
  5. as a bonus, change the event title and send an update - this update fixes the issue since other than the notification, everything works.

Expected Behaviour
the occurrence should be removed in the first update mail

Additional context
the culprits are these lines (note the comments):

recurrenceIds.push(existingInstance.startTime)

const filteredExclusions = originalExclusions.filter(({ date }) => !recurrenceTimes.includes(date.getTime()))

the event that's being deleted should not be added to the recurrenceIds since it's not going to occcur.

commit ref: bbf68fb

@ganthern ganthern added bug broken functionality, usability problems, unexpected errors topic: calendar labels Jan 28, 2025
@ganthern ganthern changed the title repeating calendar Event updates with new excluded occurrences don't get properly sent to attendees repeating calendar event updates with new excluded occurrences don't get properly sent to attendees Jan 28, 2025
@ganthern ganthern self-assigned this Jan 28, 2025
ganthern added a commit that referenced this issue Jan 29, 2025
closes #8416
fixes #bbf68fbfda09c8b0b73cbc087b68b99ee5b3e8a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors topic: calendar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant