-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[calendar] fix calendar update notifications missing new exclusions #8419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a7e0fe
to
329a3f3
Compare
Co-authored-by: jhm <17314077+jomapp@users.noreply.github.com>
the progress estimation for failed imports was not stopped. this gave the impression that the import was still ongoing. we now reset the state if an error happens during import preparation and will pause the running import if an async error happens. this will allow the user to try to resume it and see the snackbar or notification if the error happens again. also adds some local state cleanup if the import fails before being set up on the server
previously, we didn't increment the counter for all failure cases, leading to the finished import showing 0 failed mails even though some actually failed. we still leave some edge cases where we fail to import a mail but also fail to mark it as failed.
- do not depend on un-needed tokio features - move rand to Cargo.toml - use latest uniffi-bindgen from crates.io
commands like `cargo test`, `cargo clippy` or `cargo check` now require the `--all` or `--package` flags to choose which workspace members they should run for. this prevents the mobile apps from building node-mimimi
mlock is used by sqlcipher but is not allowed on our test containers see sqlcipher/sqlcipher-android#48 (comment) see systemd/systemd#9414 (comment)
- build tutasdk object file in generateBinding task note: not tested on ci/jenkins
this will improve incremental compilation times since we don't use multiple target folders anymore. Co-authored-by: sug <sug@tutao.de>
we can cut the time for the checks by 75%-80% by doing this.
Co-authored-by: sug <sug@tutao.de>
as far as I can tell, this works when sending invites to google calendar users. |
329a3f3
to
5264a92
Compare
will be part of dev-infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this might not be correct yet for invite updates sent google calendars
closes #8416
fixes bbf68fb