Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calendar] fix calendar update notifications missing new exclusions #8419

Closed
wants to merge 27 commits into from

Conversation

ganthern
Copy link
Contributor

@ganthern ganthern commented Jan 29, 2025

this might not be correct yet for invite updates sent google calendars

closes #8416
fixes bbf68fb

@ganthern ganthern force-pushed the fix-calendar-updates branch 3 times, most recently from 2a7e0fe to 329a3f3 Compare February 4, 2025 16:05
abdulkadir-tutao and others added 26 commits February 4, 2025 17:53
Co-authored-by: jhm <17314077+jomapp@users.noreply.github.com>
the progress estimation for failed imports was not stopped.
this gave the impression that the import was still ongoing.

we now reset the state if an error happens during import preparation
and will pause the running import if an async error happens.
this will allow the user to try to resume it and see the snackbar or
notification if the error happens again.

also adds some local state cleanup if the import fails before being
set up on the server
previously, we didn't increment the counter for all failure cases,
leading to
the finished import showing 0 failed mails even though some actually
failed.

we still leave some edge cases where we fail to import a mail but also
fail to mark it as failed.
- do not depend on un-needed tokio features
- move rand to Cargo.toml
- use latest uniffi-bindgen from crates.io
commands like `cargo test`, `cargo clippy` or `cargo check` now require
the `--all` or `--package` flags to choose which workspace members they
should run for.
this prevents the mobile apps from building node-mimimi
mlock is used by sqlcipher but is not allowed on our test containers
see sqlcipher/sqlcipher-android#48 (comment)
see systemd/systemd#9414 (comment)
- build tutasdk object file in generateBinding task

note: not tested on ci/jenkins
this will improve incremental compilation times since
we don't use multiple target folders anymore.

Co-authored-by: sug <sug@tutao.de>
we can cut the time for the checks by 75%-80%
by doing this.
Co-authored-by: sug <sug@tutao.de>
@ganthern
Copy link
Contributor Author

ganthern commented Feb 4, 2025

as far as I can tell, this works when sending invites to google calendar users.

@ganthern ganthern force-pushed the fix-calendar-updates branch from 329a3f3 to 5264a92 Compare February 4, 2025 17:10
@ganthern
Copy link
Contributor Author

ganthern commented Feb 4, 2025

will be part of dev-infra

@ganthern ganthern closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repeating calendar event updates with new excluded occurrences don't get properly sent to attendees
6 participants