Open email from desktop notification #7438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We got it to a state where we think it works sufficiently well. Commits need some cleanup and then it should be merged. |
charlag
force-pushed
the
7373-open-email-desktop
branch
2 times, most recently
from
a3bcaf6
to
8c4f6b1
Compare
charlag
force-pushed
the
7373-open-email-desktop
branch
from
253b444
to
a59240e
Compare
|
I put the commit to refactor EntityClient into the same PR but I can easily split it if you think it's better |
|
I re-wrote the commits so that they make more sense, please lmk if I messed something up, especially authorship. |
charlag
force-pushed
the
7373-open-email-desktop
branch
from
a59240e
to
af8a7a2
Compare
paw-hub
reviewed
Aug 26, 2024
| } | ||
|
|
||
| const cachedEntity = await this.storage.get(typeRef, listId, elementId) | ||
| let cachedEntity: T | null | ||
| if (cacheMode == CacheMode.Cache) { |
There was a problem hiding this comment.
Should probably use === here?
charlag
force-pushed
the
7373-open-email-desktop
branch
from
af8a7a2
to
3e6e852
Compare
rezbyte
approved these changes
Aug 27, 2024
charlag
force-pushed
the
7373-open-email-desktop
branch
3 times, most recently
from
646d849
to
ed9ec09
Compare
|
The fix for SSE and fix for Android are mostly unrelated but |
charlag
force-pushed
the
7373-open-email-desktop
branch
from
ed9ec09
to
6051c78
Compare
Merged
charlag
force-pushed
the
7373-open-email-desktop
branch
from
6051c78
to
d50f493
Compare
Overwrite identifier if it changed, do not duplicate user ids.
#7373 Co-authored-by: paw <paw-hub@users.noreply.github.com> Co-authored-by: ivk <ivk@tutao.de>
charlag
force-pushed
the
7373-open-email-desktop
branch
from
d50f493
to
c1ee285
Compare
paw-hub
reviewed
Sep 2, 2024
| // make sure that we display *something* in the list | ||
| await this.setListId(folderToUse) | ||
| } | ||
| if (this.stickyMailId != elementId) return |
| const folderToUse = await this.selectFolderToUse(folder ?? null) | ||
| await this.setListId(folderToUse) | ||
| // Selecting folder is async, check that the target hasn't changed inbetween | ||
| if (this.loadingTargetId != loadingTargetId) return |
|
|
||
| private readonly renderConfig: RenderConfig<Mail, MailRow> = { | ||
| itemHeight: size.list_row_height, | ||
| multiselectionAllowed: MultiselectMode.Enabled, | ||
| createElement: (dom: HTMLElement) => { | ||
| const mailRow = new MailRow(false, (entity) => this.mailViewModel.listModel?.onSingleExclusiveSelection(entity)) | ||
| const mailRow = new MailRow(false, (entity) => this.attrs?.onSingleExclusiveSelection(entity)) |
There was a problem hiding this comment.
Can this.attrs ever be null?
Show a message if the email to be opened is no longer there. Keep track of explicitly opened email independent of the list state. Handle offline errors. Fix URL and ViewSlider handling Close #7373 Co-authored-by: jat <jat@tutao.de> Co-authored-by: paw <paw-hub@users.noreply.github.com>
This improves readability and hopefully makes it harder to mix up the arguments.
charlag
force-pushed
the
7373-open-email-desktop
branch
from
c1ee285
to
8760401
Compare
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.