Sdk range request

[charlag]

(stacked on top of #7438

#7679

[paw-hub]

This could break if we add more MailSetKind types, and it won't be nice to debug. I'd do one of these two things:

• expect("Invalid mail set kind") if this is not going to happen
• unwrap_or(MailSetKind::CUSTOM) if it is a possibility

[paw-hub]

I am a little cautious around unwrapping based on data provided by the server.

I don't think there will ever be an instance where we won't have a Mail group, but just in case, I'd maybe use expect("User is not part of a mail group")

[charlag]

Most of these mail functions are not production ready yet but you are right, we should harden them a bit

[paw-hub]

For field-less enums, you can use the as operator instead of trying to match every variant. You can also derive Copy/Clone so that you can pass by value without needing to call .clone() or create a reference.

Additionally, you can manually specify what each variant is equal to.

Example:

#[repr(u64)]
#[derive(Copy, Clone, PartialEq, Debug)]
pub enum GroupType {
    User = 0,
    Admin = 1,
    MailingList = 2,
    // etc
}

impl GroupType {
    pub fn raw_value(self) -> u64 {
        self as u64
    }
}

assert_eq!(2, GroupType::MailingList as u64);
assert_eq!(2, GroupType::MailingList.raw_value());

[paw-hub]

I see you're also using num_enum, too, which could also be what you want.

[charlag]

Should be better now! thank you for the suggestions (I amended one syntax issue)