Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Bower installation download the entire Bootstrap repo? #10313

Closed
rwillrich opened this issue Aug 30, 2013 · 7 comments · Fixed by #10353
Closed

Why does Bower installation download the entire Bootstrap repo? #10313

rwillrich opened this issue Aug 30, 2013 · 7 comments · Fixed by #10353
Labels
Milestone

Comments

@rwillrich
Copy link
Contributor

I have installed Bootstrap with Bower on an application I'm developing and the fact that Bower downloads the entire repository have surprised me, given that all production files are in 'dist' directory.

Initially I've thought that it was caused by Bower, or by the lack of some configuration of him. Then I research on Bower's documentation and notice that exists a 'ignore' property on bower.json that serves for this purpose.

Shouldn't we add the files other than the production ones to this property? Or am I missing some motivation beyond maintaining all files on Bower's Bootstrap package?

@cvrebert
Copy link
Collaborator

I'm not terribly familiar with Bower, but, if you want to do any customization of Bootstrap, you need the .less files too, not just the precompiled .css. So only grabbing the /dist/ folder isn't enough in that case.

/cc @fat as Bower guru.

@thomaswelton
Copy link
Contributor

I can't really answer why it works this way. But all I can say is that it has always worked this way.
I suppose it makes it easier, as bower just has to concern it's self with downloading the latest commit or tag from what ever git remote you've specified.

If you use grunt there are many plugins you can use which will download your bower dependencies and either copy the "main" files into you public dir, or clean up the files you don't need from the repo for you automatically.

But either way I suppose this question would be best asked in the bower fourms or repo, as this isn't specific to botstrap.

@cvrebert
Copy link
Collaborator

Closing per @thomaswelton

@boulox
Copy link
Contributor

boulox commented Aug 31, 2013

that not 100% true, you can definitely define some parameter in the bower.json. Bower won't download anything that it's in the ignore list Such as :

{
   ........
    "ignore": [
        ".*",
        "CHANGELOG.md",
        "component.json",
        "package.json",
        "_includes"
        "_layouts"
    ]
}

I 2nd the issue when installing with bower i don't want the doc files

@rwillrich
Copy link
Contributor Author

+1 But that is my question is: should we make this? At least with some documentation and files that don't are important in the build process.

@cvrebert
Copy link
Collaborator

I'll leave this for @fat to sort out.

@cvrebert cvrebert reopened this Aug 31, 2013
@rwillrich
Copy link
Contributor Author

I've submitted in my fork and made a pull request for it: #10353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants