Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carousel prev selector #13818

Closed
nicolasroux opened this issue Jun 13, 2014 · 2 comments · Fixed by #14069
Closed

carousel prev selector #13818

nicolasroux opened this issue Jun 13, 2014 · 2 comments · Fixed by #14069
Labels
Milestone

Comments

@nicolasroux
Copy link

In Carousel.prototype.slide function, replace line 3:
var $next = next || $activetype
with:
var $next = next || $activetype
to ensure selected element is a carousel item (i have a scenario with a hidden div inside my carousel)

@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 13, 2014

Related to #9461.

/cc @fat

@cvrebert cvrebert added the js label Jun 13, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Jun 13, 2014
@mdo
Copy link
Member

mdo commented Jul 7, 2014

The proposed fix doesn't work. Instead of skipping to the next element—after a hidden <div>—it starts over again. It doesn't move to the third item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants