Use more robust "find next carousel item" logic #14069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is due to the unrelated transient IE8 issue that Jacob is gonna look into. |
| var delta = direction == 'prev' ? -1 : 1 | ||
| var activeIndex = this.getItemIndex(active) | ||
| var itemIndex = (activeIndex + delta) % this.$items.length | ||
| return $(this.$items[itemIndex]) |
There was a problem hiding this comment.
How about return this.$items.eq(itemIndex) here? (Could do the same thing here.)
|
@fat Ping. |
|
lgtm |
|
probably should squash these commits |
Also adds another test for #9461: carousel next/prev should ignore non-items
|
Squashed. |
cvrebert
added a commit
that referenced
this pull request
Jul 31, 2014
Use more robust "find next carousel item" logic
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13818 and adds a relevant additional test.
CC: @fat for review