Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant code? #8991

Closed
h0wn0w opened this issue Aug 1, 2013 · 2 comments
Closed

Redundant code? #8991

h0wn0w opened this issue Aug 1, 2013 · 2 comments

Comments

@h0wn0w
Copy link

h0wn0w commented Aug 1, 2013

This could just be a limitation of my knowledge of bespoke css, but it seems there is redundant code in /dist/css/bootstrap.css (and, presumably in the .min file).

Lines 723 - 761 contain repeats, e.g.,

.container:before,
.container:after {
  display: table;
  content: " ";
}

.container:after {
  clear: both;
}

.container:before,
.container:after {
  display: table;
  content: " ";
}

etc. I did not see this anywhere else in the .css issues, so I apologize if this is known.
@cvrebert
Copy link
Collaborator

cvrebert commented Aug 1, 2013

Duplicate of #8947. Please search next time.

@cvrebert cvrebert closed this as completed Aug 1, 2013
@h0wn0w
Copy link
Author

h0wn0w commented Aug 1, 2013

Yeah, I did, just must have overlooked it or something. Thank you for the reply.

W. Howard Buddin Jr., Ph.D.
Site: theresearchdynamo.com
Twit: @hbuddin

On Aug 1, 2013, at 4:47 PM, Chris Rebert notifications@github.com wrote:

Duplicate of #8947. Please search next time.

—
Reply to this email directly or view it on GitHub.

mdo added a commit that referenced this issue Dec 9, 2013
@mdo
Switch to &:extend(.clearfix all) for clearfix mixin
0016c17 
Original discussion:
less/less.js#1437 (comment).

Since we’re switching to `grunt-contrib-less`, we can take advantage of
newer LESS features than what RECESS supported. Included in that is the
ability to `:extend`, and not only that, but `:extend(.mixin-name
all)`. By doing so, we remove duplicate CSS for all our elements that
were being clearfix-ed.

Fixes #8947, #8968, #8991, #9257, #9268, #9291, #9430, #9604, #9686,
#9929, #10731, #10793, #11305, #11498, #11533, #11570, #11604, #11652.

(dem issues, tho)
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
@mdo
(less) Switch to &:extend(.clearfix all) for clearfix mixin
aa17961 
Original discussion:
less/less.js#1437 (comment).

Since we’re switching to `grunt-contrib-less`, we can take advantage of
newer LESS features than what RECESS supported. Included in that is the
ability to `:extend`, and not only that, but `:extend(.mixin-name
all)`. By doing so, we remove duplicate CSS for all our elements that
were being clearfix-ed.

Fixes twbs#8947, twbs#8968, twbs#8991, twbs#9257, twbs#9268, twbs#9291, twbs#9430, twbs#9604, twbs#9686,
twbs#9929, twbs#10731, twbs#10793, twbs#11305, twbs#11498, twbs#11533, twbs#11570, twbs#11604, twbs#11652.

(dem issues, tho)
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Switch to &:extend(.clearfix all) for clearfix mixin
de027d8 
Original discussion:
less/less.js#1437 (comment).

Since we’re switching to `grunt-contrib-less`, we can take advantage of
newer LESS features than what RECESS supported. Included in that is the
ability to `:extend`, and not only that, but `:extend(.mixin-name
all)`. By doing so, we remove duplicate CSS for all our elements that
were being clearfix-ed.

Fixes twbs#8947, twbs#8968, twbs#8991, twbs#9257, twbs#9268, twbs#9291, twbs#9430, twbs#9604, twbs#9686,
twbs#9929, twbs#10731, twbs#10793, twbs#11305, twbs#11498, twbs#11533, twbs#11570, twbs#11604, twbs#11652.

(dem issues, tho)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvrebert @h0wn0w