Remove duplicate CSS caused by mixins #10731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s going to be accessible as a class. Removed the classes which has already been declared as mixins without parentheses, as they will be added to the final CSS. In LESS any class can be used as a mixin, but when we declare a mixin and afterwards add a class with the same name, LESS actually duplicates the mixin. When we apply e.g. the .clearfix to the .row-selector, the clearfix CSS is added twice to the final CSS.
|
X-Ref: #8947, less/less.js#1437 |
|
The problem with this is that the mixins.less generates CSS, something a number of folks absolutely hate. Last I saw it wasn't solvable fully until Less 1.4? Unsure about that last part. Definitely not 100% happy about that. More than that, however, are all the deletions in the compiled CSS. Note that many of the clearfix-ed elements no longer have any clearfix properties. Whatever we change for this cannot affect the generated CSS. |
mdo
added a commit
that referenced
this pull request
Dec 9, 2013
Original discussion: less/less.js#1437 (comment). Since we’re switching to `grunt-contrib-less`, we can take advantage of newer LESS features than what RECESS supported. Included in that is the ability to `:extend`, and not only that, but `:extend(.mixin-name all)`. By doing so, we remove duplicate CSS for all our elements that were being clearfix-ed. Fixes #8947, #8968, #8991, #9257, #9268, #9291, #9430, #9604, #9686, #9929, #10731, #10793, #11305, #11498, #11533, #11570, #11604, #11652. (dem issues, tho)
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
Original discussion: less/less.js#1437 (comment). Since we’re switching to `grunt-contrib-less`, we can take advantage of newer LESS features than what RECESS supported. Included in that is the ability to `:extend`, and not only that, but `:extend(.mixin-name all)`. By doing so, we remove duplicate CSS for all our elements that were being clearfix-ed. Fixes twbs#8947, twbs#8968, twbs#8991, twbs#9257, twbs#9268, twbs#9291, twbs#9430, twbs#9604, twbs#9686, twbs#9929, twbs#10731, twbs#10793, twbs#11305, twbs#11498, twbs#11533, twbs#11570, twbs#11604, twbs#11652. (dem issues, tho)
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Original discussion: less/less.js#1437 (comment). Since we’re switching to `grunt-contrib-less`, we can take advantage of newer LESS features than what RECESS supported. Included in that is the ability to `:extend`, and not only that, but `:extend(.mixin-name all)`. By doing so, we remove duplicate CSS for all our elements that were being clearfix-ed. Fixes twbs#8947, twbs#8968, twbs#8991, twbs#9257, twbs#9268, twbs#9291, twbs#9430, twbs#9604, twbs#9686, twbs#9929, twbs#10731, twbs#10793, twbs#11305, twbs#11498, twbs#11533, twbs#11570, twbs#11604, twbs#11652. (dem issues, tho)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed parentheses in declaration of mixins (in mixins.less) which is going to be accessible as a class.
Removed the classes (in utilities.less) which has already been declared as mixins without parentheses, as they will be added to the final CSS.
In LESS any class can be used as a mixin, but when we declare a mixin and afterwards add a class with the same name, LESS actually duplicates the mixin. When we apply e.g. the .clearfix to the .row-selector, the clearfix CSS is added twice to the final CSS.