Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style .input-group-btn according to form validation state #12740

Closed
wants to merge 1 commit into from

Conversation

gxclarke
Copy link

Apply validation state styling to buttons contained within input groups, similarly to what is already done for addons within input groups.

Apply validation state styling to buttons contained within input groups, similarly to what is already done for addons within input groups.
@cvrebert cvrebert added the css label Feb 14, 2014
@cvrebert
Copy link
Collaborator

Please also include the generated /dist/css/bootstrap.css file.

@cvrebert
Copy link
Collaborator

I don't know if this is advisable. It has the effect of completely overriding the color scheme of the button itself (e.g. if the button is .btn-success and the form group is .has-error, the button's background will be red). Not obvious what the right behavior is in such cases.

X-Ref: #11659

@zlatanvasovic
Copy link
Contributor

Just change .btn-default to .btn-<state>. I don't see a point for this. What if I want success button in warning form, or something similar? This disallows developers to customize button look without adding !important.

@mdo
Copy link
Member

mdo commented Feb 14, 2014

The styling was not missed—it's passed over on purpose. Showing say a red border on a primary (blue) button doesn't make a lot of sense. And the button isn't the thing that's got the error—that's the input.

@mdo mdo closed this Feb 14, 2014
@zlatanvasovic
Copy link
Contributor

Yes, makes sense.

2014-02-14 21:30 GMT+01:00 Mark Otto notifications@github.com:

Closed #12740 #12740.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12740
.

Zlatan Vasović - ZDroid

@twbs twbs locked and limited conversation to collaborators Jan 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants