-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #15597 — Mention dropup variation in dropdown docs #15659
Conversation
Conflicts: CHANGELOG.md Makefile README.md component.json docs/assets/css/bootstrap-responsive.css docs/assets/css/bootstrap.css docs/assets/js/bootstrap-affix.js docs/assets/js/bootstrap-alert.js docs/assets/js/bootstrap-button.js docs/assets/js/bootstrap-carousel.js docs/assets/js/bootstrap-collapse.js docs/assets/js/bootstrap-dropdown.js docs/assets/js/bootstrap-modal.js docs/assets/js/bootstrap-popover.js docs/assets/js/bootstrap-scrollspy.js docs/assets/js/bootstrap-tab.js docs/assets/js/bootstrap-tooltip.js docs/assets/js/bootstrap-transition.js docs/assets/js/bootstrap-typeahead.js docs/assets/js/bootstrap.js docs/assets/js/bootstrap.min.js docs/base-css.html docs/components.html docs/customize.html docs/extend.html docs/getting-started.html docs/index.html docs/javascript.html docs/scaffolding.html docs/templates/pages/index.mustache js/bootstrap-affix.js js/bootstrap-alert.js js/bootstrap-button.js js/bootstrap-carousel.js js/bootstrap-collapse.js js/bootstrap-dropdown.js js/bootstrap-modal.js js/bootstrap-popover.js js/bootstrap-scrollspy.js js/bootstrap-tab.js js/bootstrap-tooltip.js js/bootstrap-transition.js js/bootstrap-typeahead.js less/bootstrap.less less/responsive.less package.json
Fix issue twbs#15597 — Mention dropup variation in dropdown docs
Should probably also be used in some example in that section. |
Replace single line comment with subsection touching on the variation with an example
Updated from a single line comment to a small "Dropup Variation" section with an example. Thanks for the feedback. |
Please squash this into a single commit. |
Will do when I get home. Thanks for your feedback on this. Please excuse brevity — Sent from my mobile device.
|
Fix issue twbs#15597 — Mention dropup variation in dropdown docs Replace single line comment with subsection Replace single line comment with subsection touching on the variation with an example Fix duplicate ID's Missed an aria label There's already a dropdownMenu2 So many dropdown menus…
OK, after attempting this apparently I messed it up with rebase, what's the command to make it a single commit? I tried git rebase -i origin/master |
|
No clue how to save this stupid pull request so just made a new one... |
Mention dropup variation in dropdown docs
Fixes #15597.