-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #15597 — Mention dropup variation in dropdown docs #15662
Conversation
Fix issue twbs#15597 — Mention dropup variation in dropdown docs Other pull request was so messed up I sincerely have no clue how to save it. The recommended command doesn't work, can't believe rebasing is so problematic...
CC: @mdo |
|
I'm not sure I follow you @vsn4ik on point 3 |
* Remove `<h3>Example</h3>;` * Move `data-example-id=""` to `<h3>Dropup Variation</h3>` and change value;
My mistake on point 2:
|
data-example-id not need be moved. Only change, because data-example-id="static-dropdown" already exists. Remove whitespace after h3. Variation not need capitalize.
<h3 id="dropdowns-dropup">Dropup variation</h3> | ||
<p>Trigger dropdown menus above elements by adding <code>.dropup</code> to the parent.</p> | ||
<div class="bs-example" data-example-id="static-dropup"> | ||
<div class="dropup clearfix"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I add the clearfix
at some point, or is that new to this PR?
My only concern with this is that it's basically an exact dupe of another docs section. |
I didn't add one to this. I copied and pasted to use what you had. I had started with a small note only, what would you be interested in as a solution? |
Yeah, I think so @kkirsche. |
@mdo What do you think about the following idea: In the example section we add the following sentence:
Then in the example section include one of each. This way, we reduce the space necessary by not including a standalone example for just the dropup variation. The other idea I have would be to include the following sentence with no visible example:
What is your preference? |
A live example to go with it is probably preferable, so we can go with that. |
Condense the dropup example
Changed to the first option which uses short sentence with a live example in the first example box. |
@mdo LGTY? |
Fix issue #15597 — Mention dropup variation in dropdown docs
Thanks guys! 👍 |
Fixes #15597. Mention dropup variation in dropdown docs
Other pull request (#15659) was so messed up I sincerely have no clue how to save it. The recommended command doesn't work, can't believe rebasing is so problematic...