Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 - Accordion example should use cards #17159

Merged
merged 1 commit into from
Sep 8, 2016
Merged

v4 - Accordion example should use cards #17159

merged 1 commit into from
Sep 8, 2016

Conversation

kkirsche
Copy link
Contributor

Partial Fix: #17157 #18375

Additional code needed to get cards to butt up against each other as expected.
Original (V3) isn't butted up against each other

Result:
screen shot 2015-08-20 at 3 36 08 pm

Partial Fix: twbs#17157

Additional code needed to get cards to butt up against each other as expected.
@hkdobrev
Copy link
Contributor

You could use .card-text to better show the usage of cards as many people would copy from this example.

@kkirsche
Copy link
Contributor Author

To me card text doesn't look right. If that's what people suggest I can but I personally don't find that to look like what I'd expect from an accordion.

@mdo mdo mentioned this pull request Dec 8, 2015
8 tasks
@mdo mdo merged commit b3125aa into twbs:v4-dev Sep 8, 2016
@mdo mdo added this to the v4.0.0-alpha.5 milestone Sep 8, 2016
@mdo mdo mentioned this pull request Sep 8, 2016
@kkirsche kkirsche deleted the patch-21 branch September 8, 2016 18:23
@ryannealmes
Copy link

ryannealmes commented Oct 11, 2016

Hey guys,

I am playing around with v4 and noticed that the funcitonality for accordian doesn't quite match the existing functionality. It seems that the accordian does not collapse open cards when you click on another card (note this seems to work as expected when using panels).

See fiddle for example.

http://v4-alpha.getbootstrap.com/components/collapse/#accordion-example

Am I missing something? Maybe a setting?

Thanks.

@twbs-lmvtfy
Copy link

Hi @ryannealmes!

You appear to have posted a live example (https://fiddle.jshell.net/aswognd9/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

  • line 101, column 1 thru column 7: End tag for body seen, but there were unclosed elements.
  • line 63, column 3 thru column 65: Unclosed element div.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@mdo
Copy link
Member

mdo commented Oct 11, 2016

Different issue and there's a PR to address it I believe.

@kkirsche
Copy link
Contributor Author

Thanks, @mdo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants