Convert Collapse accordion from Panels to Cards #18400

Johann-S · 2015-12-01T22:26:57Z

Hi,

But with this PR Collapse plugin is now dependent of cards, So if you're ok with that I'll work on how to remove this dependency.

A preview from the result :

cvrebert · 2015-12-01T23:12:35Z

Could you update the Accordion in js/tests/visual/modal.html too please?

cvrebert · 2015-12-01T23:14:04Z

But with this PR Collapse plugin is now dependent of cards, So if you're ok with that

Yeah, that's fine. We can leave removing the dependency to a future pull request.

CC: @mdo for review

Johann-S · 2015-12-02T07:20:42Z

Done for the modal.html collapse.

Thank you for your feedbacks

cvrebert · 2015-12-23T22:46:09Z

Overlaps with #17159.

cvrebert · 2015-12-23T22:48:03Z

scss/_card.scss

@@ -19,6 +19,10 @@
 margin-bottom: $card-spacer-y;
 }

+.card-title > a {


Hmm, in general, we're trying to avoid tag selectors and child selectors.

Johann-S · 2015-12-24T13:42:03Z

I did changes 👍

houndci-bot · 2016-09-08T09:23:19Z

js/tests/unit/collapse.js

 + '</div>'
 var showFired = false
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

Johann-S · 2016-09-08T09:26:24Z

Since the merge of #17159 by @mdo I rebased my PR.

Johann-S · 2016-09-09T14:52:04Z

This is why I created a class .card-collapse .

With .card-collapse :

With .card-block :

/CC @cvrebert @mdo

mdo · 2016-10-10T20:02:49Z

Hey @Johann-S, I missed this completely. Can you update this PR to resolve the conflicts? Would love to get this merged :). I'd also ask that you use the changes I made in #20870 so we can avoid the addition of .card-collapse entirely.

Johann-S · 2016-10-10T20:18:28Z

Sure I'll work on it !

houndci-bot · 2016-10-11T08:40:52Z

js/tests/unit/collapse.js

 + '</div>'
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T08:40:53Z

js/tests/unit/collapse.js

- + '<div class="panel"/>'
- + '<div class="panel"/>'
- + '<div class="panel"/>'
+ var accordionHTML = '<div id="accordion">'


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T08:40:53Z

js/tests/unit/collapse.js

 + '</div>'
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T08:47:00Z

js/tests/unit/collapse.js

 + '</div>'
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T08:47:00Z

js/tests/unit/collapse.js

- + '<div class="panel"/>'
- + '<div class="panel"/>'
- + '<div class="panel"/>'
+ var accordionHTML = '<div id="accordion">'


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T08:47:01Z

js/tests/unit/collapse.js

 + '</div>'
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

Johann-S · 2016-10-11T09:09:06Z

Thank you @mdo for what you've done on #20870.
And it's done I've made the changes 👍

houndci-bot · 2016-10-11T11:27:36Z

js/tests/unit/collapse.js

 + '</div>'
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T11:27:36Z

js/tests/unit/collapse.js

- + '<div class="panel"/>'
- + '<div class="panel"/>'
- + '<div class="panel"/>'
+ var accordionHTML = '<div id="accordion">'


Unexpected var, use let or const instead no-var

houndci-bot · 2016-10-11T11:27:36Z

js/tests/unit/collapse.js

 + '</div>'
- var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.panel')
+ var $groups = $(accordionHTML).appendTo('#qunit-fixture').find('.card')


Unexpected var, use let or const instead no-var

mdo · 2016-10-11T17:23:24Z

Do we need to silence these Hound errors or is there something else we need to change?

mdo · 2016-10-11T17:27:14Z

Oh wait, sorry missed the file that's in—we're working on the test files elsewhere I think. Cool!

Johann-S · 2016-10-19T18:10:44Z

I think @mdo you forget this PR in the v4 Alpha 5 Ship list (#20630) or I'm wrong ?

cvrebert added js css v4 labels Dec 1, 2015

cvrebert changed the title ~~[V4] Collapse using card component~~ Convert Collapse accordion from Panels to Cards Dec 1, 2015

Johann-S mentioned this pull request Dec 16, 2015

v4: Cards #18468

Closed

8 tasks

cvrebert reviewed Dec 23, 2015
View reviewed changes

houndci-bot reviewed Sep 8, 2016
View reviewed changes

Johann-S mentioned this pull request Sep 8, 2016

v4 - Move collapse js away from panels to cards #17171

Closed

mdo added this to the v4.0.0-alpha.5 milestone Oct 10, 2016

houndci-bot reviewed Oct 11, 2016

View reviewed changes

Collapse using card component

de1255b

houndci-bot reviewed Oct 11, 2016

View reviewed changes

mdo merged commit 97b9d12 into twbs:v4-dev Oct 11, 2016

mdo mentioned this pull request Oct 11, 2016

Collapse Accordion is still using Panels #18375

Closed

Johann-S deleted the collapseCard branch October 11, 2016 20:25

Johann-S mentioned this pull request Dec 23, 2016

scrollspy: fix wrong activation of all nested links #20304

Merged

Johann-S mentioned this pull request Jan 12, 2017

Table hover, accent, active variables for both table and table-inverse #21676

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert Collapse accordion from Panels to Cards #18400

Convert Collapse accordion from Panels to Cards #18400

Johann-S commented Dec 1, 2015

cvrebert commented Dec 1, 2015

cvrebert commented Dec 1, 2015

Johann-S commented Dec 2, 2015

cvrebert commented Dec 23, 2015

cvrebert Dec 23, 2015

Johann-S commented Dec 24, 2015

houndci-bot Sep 8, 2016

Johann-S commented Sep 8, 2016

Johann-S commented Sep 9, 2016

mdo commented Oct 10, 2016

Johann-S commented Oct 10, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

Johann-S commented Oct 11, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

houndci-bot Oct 11, 2016

mdo commented Oct 11, 2016

mdo commented Oct 11, 2016 •

edited

Loading

Johann-S commented Oct 19, 2016

Convert Collapse accordion from Panels to Cards #18400

Convert Collapse accordion from Panels to Cards #18400

Conversation

Johann-S commented Dec 1, 2015

cvrebert commented Dec 1, 2015

cvrebert commented Dec 1, 2015

Johann-S commented Dec 2, 2015

cvrebert commented Dec 23, 2015

Choose a reason for hiding this comment

Johann-S commented Dec 24, 2015

Choose a reason for hiding this comment

Johann-S commented Sep 8, 2016

Johann-S commented Sep 9, 2016

mdo commented Oct 10, 2016

Johann-S commented Oct 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Johann-S commented Oct 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdo commented Oct 11, 2016

mdo commented Oct 11, 2016 • edited Loading

Johann-S commented Oct 19, 2016

mdo commented Oct 11, 2016 •

edited

Loading