Table hover, accent, active variables for both table and table-inverse #21676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
reviewed
Jan 12, 2017
| @@ -81,6 +81,11 @@ | |||
| tbody tr { | |||
| @include hover { | |||
| background-color: $table-bg-hover; | |||
|
|
|||
| > td, | |||
| > th { | |||
There was a problem hiding this comment.
It seems Bootstrap's team try to avoid child selector, see this comment for exemple : #18400 (comment)
There was a problem hiding this comment.
Yes indeed.
There was also children selector in _table-row.scss that were there before my PR. I removed them as well for consistency.
Good catch, thanks !
|
Would two different mixins be better for this to avoid the weird (to me) |
|
Sure! I made the change. |
Merged
|
Sorry, forgot about this PR! Closing for #22217 and skipping the new hover styles for contextual classes. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21002 and add other customization possibilities for table variables.
table-inversetable-hover(both for regular and inverse table)table-hoverwith a hoveredtrthat had a different background color than a tr withtable-activewhile they are supposed to be the same according to contextual-classestable-hover,table-inverseand row variations.