Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar IE #23652

Merged
merged 4 commits into from
Sep 12, 2017
Merged

Fix navbar IE #23652

merged 4 commits into from
Sep 12, 2017

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Aug 24, 2017

Fixes #23531.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 26, 2017

@MartijnCuppens: does this change the behavior with other browsers?

I can confirm it does fix the issue on IE 10.

/CC @mdo

@MartijnCuppens
Copy link
Member Author

@XhmikosR, should be ok (tested in latest versions of Edge, Chrome, FF). flex-grow: 1 also is a more logic choice over flex-basis: 100% because the element will never be 100% but just needs to fill the available space.

@XhmikosR
Copy link
Member

Indeed, makes more sense.

I'll let @mdo take the final decision.

@XhmikosR
Copy link
Member

ping @mdo; we need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants