bug fix: Fixes #23926 responsive state on navbar

[andresgalante]

#23652 fixes IE10 but introduces a bug on small devices on navbar on any browser, you can test it on v4-dev branch.

This PR closes #23926.

I've tested on IE10 up and other modern browsers.

@XhmikosR @mdo can you please review it?

[XhmikosR]

Will do as soon as I'm back, thanks!

…

On Sep 12, 2017 21:58, "Andres Galante" ***@***.***> wrote: This #23652 <#23652> fixes IE10 but introduces a bug on small devices on navbar. This PR closes #23926 <#23926>. I've tested on IE10 up and other modern browsers. @XhmikosR <https://github.com/xhmikosr> @mdo <https://github.com/mdo> can you please review it? ------------------------------ You can view, comment on, or merge this pull request online at: #23929 Commit Summary - fixes #23926 responsive state on navbar File Changes - *M* scss/_navbar.scss <https://github.com/twbs/bootstrap/pull/23929/files#diff-0> (6) Patch Links: - https://github.com/twbs/bootstrap/pull/23929.patch - https://github.com/twbs/bootstrap/pull/23929.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23929>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtTl4JpFycvvspX1dlOkGx-7GjSrhks5shtRNgaJpZM4PVF9Q> .

[Fouzyyyy]

Hi @andresgalante,

Just tested the pushed code, there is an issue with the Firefox browser v54.0, Chrome 60.0.3112.113, in the responsive mode (900 * 480) for instance. It's the same behavior reported in #23926

[XhmikosR]

@mdo: please have a look too; I confirmed it fixes the regression and also works on IE

[andresgalante]

@Fouzyyyy you are right, the issue persists on the examples on the docs but not on the examples/jumbotron/ example.

My fix needs to be related to the breakpoint it expands as seen here /examples/navbars/

I'll update the PR. (IE10 💩 )

[mdo]

@andresgalante Do you have an update here for the fix? If it'll take some time, I'm probably going to revert the original PR instead to fix the newest bug.

[andresgalante]

@mdo Yes, just updated it, its ready to merge now. Don't revert the original PR since we kinda need it to both kill IE10 bug and make this solution work. Sorry for the delay, I went for dinner and just got back to it 😝

@XhmikosR and @Fouzyyyy Thanks a lot for reviewing this PR and helping out finding the problems

[mdo]

Weirdly I was building files locally and accidentally pushed before hitting submit on my review. Thanks, @andresgalante!