Adds a note on typography docs about using rem
s for font-size-base
#23988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading this issue #23982 I've added a note on the docs related to how to set
font-size-base
units.My guess is that other users will try to set font size base in px and they'll get a sass error too.
I've also changed the responsive typography example from
px
s torem
s to help copy-and-paste users get an accessible website.What do you think?