Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a note on typography docs about using rems for font-size-base #23988

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Adds a note on typography docs about using rems for font-size-base #23988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/4.0/content/typography.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Bootstrap sets basic global display, typography, and link styles. When more cont
- Set the global link color via `$link-color` and apply link underlines only on `:hover`.
- Use `$body-bg` to set a `background-color` on the `<body>` (`#fff` by default).

These styles can be found within `_reboot.scss`, and the global variables are defined in `_variables.scss`.
These styles can be found within `_reboot.scss`, and the global variables are defined in `_variables.scss`. Make sure to set `$font-size-base` in `rem`.

## Headings

Expand Down Expand Up @@ -297,24 +297,24 @@ Here's an example of it in practice. Choose whatever `font-size`s and media quer

{% highlight scss %}
html {
font-size: 14px;
font-size: 1rem;
}

@include media-breakpoint-up(sm) {
html {
font-size: 16px;
font-size: 1.2rem;
}
}

@include media-breakpoint-up(md) {
html {
font-size: 20px;
font-size: 1.4rem;
}
}

@include media-breakpoint-up(lg) {
html {
font-size: 28px;
font-size: 1.6rem;
}
}
{% endhighlight %}