Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip hidden dropdowns while focusing #29523

Merged
merged 9 commits into from
Oct 17, 2019
Merged

Skip hidden dropdowns while focusing #29523

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4175399
Skip hidden dropdowns while focusing
jeremyvii Oct 14, 2019
883b5a3
Merge branch 'master' into skip-hidden-dropdowns
jeremyvii Oct 14, 2019
808d6b4
Check for class that sets element as hidden
jeremyvii Oct 15, 2019
ce4d3dc
Add test for skipping hidden elements
jeremyvii Oct 15, 2019
705e065
Check computed CSS rather than inline styles
jeremyvii Oct 15, 2019
e267f81
Remove extra event dispatch
jeremyvii Oct 16, 2019
f5eab31
Merge branch 'master' into skip-hidden-dropdowns
jeremyvii Oct 16, 2019
110b5f9
Merge branch 'master' into skip-hidden-dropdowns
jeremyvii Oct 16, 2019
5451aec
Merge branch 'master' into skip-hidden-dropdowns
jeremyvii Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/src/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
getjQuery,
getElementFromSelector,
isElement,
isVisible,
makeArray,
noop,
typeCheckConfig
Expand Down Expand Up @@ -478,6 +479,7 @@ class Dropdown {
}

const items = makeArray(SelectorEngine.find(Selector.VISIBLE_ITEMS, parent))
.filter(isVisible)

if (!items.length) {
return
Expand Down