-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip hidden dropdowns while focusing #29523
Conversation
not had a chance to test, but i'll just throw out that you might also need to check for visible, but disabled, ones as well |
I think disabled items are ignored per this dropdown selector here, but I will double check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeremyvii,
Thanks for your PR!
Can you add a unit test please ?
While adding this unit test, I had noticed that |
I was just reviewing the change I made, and think it may be better to use |
This PR fixes issue #29405 by filtering out dropdown items set to
display: none
when focusing between items. TheisVisible()
utility method filters out the hidden items.