Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4-dev backports and updates #29542

Merged
merged 10 commits into from
Nov 2, 2019
Merged

v4-dev backports and updates #29542

merged 10 commits into from
Nov 2, 2019

Conversation

XhmikosR
Copy link
Member

No description provided.

@XhmikosR XhmikosR added the v4 label Oct 17, 2019
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 6 times, most recently from 15d4c8a to 51151d3 Compare October 24, 2019 08:25
@XhmikosR
Copy link
Member Author

We need to backport #29523 but it needs to be a manual backport...

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 5 times, most recently from d16a31b to 42defcd Compare October 28, 2019 14:32
@XhmikosR XhmikosR marked this pull request as ready for review October 28, 2019 14:45
@XhmikosR XhmikosR requested review from a team as code owners October 28, 2019 14:45
@XhmikosR
Copy link
Member Author

As of now we have 2 PRs

  1. Add "add" and "subtract" func to return valid calc #28915 that needs to be manually backported
  2. Fix Modal compensation padding #29320 that I'm not sure if it's ready yet. But it's quite an important issue and would be nice if we could get it merged in master and backported here

@ferbinu
Copy link

ferbinu commented Nov 1, 2019

when v4.4.0 release?

@XhmikosR
Copy link
Member Author

XhmikosR commented Nov 1, 2019

We are close to it, but please be patient. It's mostly a matter of getting the release notes/blog post ready, and finding the time to do it. Assuming #29320 is sorted in a timely manner.

@XhmikosR XhmikosR merged commit 0aa6a81 into v4-dev Nov 2, 2019
@XhmikosR XhmikosR deleted the v4-dev-xmr branch November 2, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants