Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct color for popover header bottom border #34006

Merged
merged 0 commits into from
May 18, 2021
Merged

Set the correct color for popover header bottom border #34006

merged 0 commits into from
May 18, 2021

Conversation

brneor
Copy link
Contributor

@brneor brneor commented May 17, 2021

Fixes #34005

@brneor brneor requested a review from a team as a code owner May 17, 2021 12:49
@brneor brneor changed the title Sets the correct color for popover header bottom border (twbs#34005) Sets the correct color for popover header bottom border May 17, 2021
@ffoodd
Copy link
Member

ffoodd commented May 17, 2021

Not quite sure about this: the existing border color is meant to be a shade of the background color. That's questionable and I tend to agree with your suggestion, but it's more a design decision than a CSS one. @mdo, your call :)

@brneor
Copy link
Contributor Author

brneor commented May 17, 2021

Not quite sure about this: the existing border color is meant to be a shade of the background color. That's questionable and I tend to agree with your suggestion, but it's more a design decision than a CSS one. @mdo, your call :)

I was in doubt if this was a flaw or a design choice, but as I stated on #34005, it differs from the card-header behavior.

@ffoodd
Copy link
Member

ffoodd commented May 17, 2021

Well, they aren't the same component, so they may differ :D In this case, popover lies above another content, so its surrounding borders are more important than card's ones IMHO. But I agree it'd be more consistent, even in the component scope.

@XhmikosR XhmikosR changed the title Sets the correct color for popover header bottom border Set the correct color for popover header bottom border May 18, 2021
@XhmikosR XhmikosR requested a review from mdo May 18, 2021 06:10
@XhmikosR XhmikosR merged commit 2757fbe into twbs:main May 18, 2021
@brneor
Copy link
Contributor Author

brneor commented May 18, 2021

Looks like pull bot messed up this PR...

@XhmikosR
Copy link
Member

@brneor please make a new PR and ideally don't use that bot please.

@brneor
Copy link
Contributor Author

brneor commented May 18, 2021

@XhmikosR done in #34026. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom border of 'popover-header' does not respect value specified for $popover-border-color
3 participants