Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the correct color for popover header bottom border #34026

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Sets the correct color for popover header bottom border #34026

merged 4 commits into from
Jun 3, 2021

Conversation

brneor
Copy link
Contributor

@brneor brneor commented May 18, 2021

Fixes #34005.

Pull bot accidentally messed up PR #34006, so I disabled it and created this one. Sorry for my naivety 😄

@ffoodd ffoodd requested a review from mdo May 18, 2021 12:35
@ffoodd
Copy link
Member

ffoodd commented May 18, 2021

@mdo still need your review here, mostly a design choice IMHO: should the popover header border match the header background, or the popover border?

@alpadev
Copy link
Contributor

alpadev commented May 28, 2021

@mdo still need your review here, mostly a design choice IMHO: should the popover header border match the header background, or the popover border?

Friendly pinging 👉 @mdo

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like the lighter border, but this is clearer and more expected IMO. Thanks!

@mdo mdo merged commit c0d21e1 into twbs:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom border of 'popover-header' does not respect value specified for $popover-border-color
6 participants