Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon link: envariable + enhance the documentation #38130

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Icon link: envariable + enhance the documentation #38130

merged 3 commits into from
Mar 2, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 28, 2023 •
edited
Loading

Description

Introduce some Sass variables to better handle the default .icon-link.
Adding some docs about this variables and display some ways to custom those links.
Add fill: currentcolor for icons.

Motivation & Context

Better customization for end users.
Adding some CSS that comes from the docs CSS atm.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@louismaximepiton louismaximepiton requested a review from a team as a code owner February 28, 2023 09:28
@louismaximepiton louismaximepiton mentioned this pull request Feb 28, 2023
Merged
1 task
mdo
mdo approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! <3

@mdo mdo merged commit 7832136 into main Mar 2, 2023
@mdo mdo deleted the main-lmp-icon-link-enhancement branch March 2, 2023 18:32
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @mdo