Skip to content
This repository has been archived by the owner on Aug 20, 2023. It is now read-only.

[BUG] CI is failing due to wrong diff comparison in Danger #2046

Closed
dkundel opened this issue Apr 15, 2020 · 8 comments
Closed

[BUG] CI is failing due to wrong diff comparison in Danger #2046

dkundel opened this issue Apr 15, 2020 · 8 comments
Labels
bug Something isn't working stale

Comments

@dkundel
Copy link
Member

dkundel commented Apr 15, 2020

Description

Right now the CI is failing on basically every run because it complains that people removed pixels from others. It appears to be because it's using the wrong diff for the check.

Expected Behavior

PRs like this one should succeed: #2045

Actual Behavior

PR failed because it's claiming it removed additional pixels https://github.com/twilio-labs/open-pixel-art/pull/2045/checks?check_run_id=589878945

Possible Fix

The diff that's being generated by Danger seems to be wrong. I did some digging but couldn't figure out yet how to get the merge commit instead. I asked on Spectrum but haven't heard back yet. Next step would probably be to report a bug on danger/danger-js.

Steps to Reproduce

  1. Check the changes in this PR: https://github.com/twilio-labs/open-pixel-art/pull/2045/files
  2. There is clearly only one line added
  3. Check the Danger logs of https://github.com/twilio-labs/open-pixel-art/pull/2045/checks?check_run_id=589878945
  4. It says it failed because pixels were removed.

Context

This is currently blocking the automatic PR experience for users.

@mergify mergify bot mentioned this issue Jul 31, 2022
4 tasks
@mergify mergify bot mentioned this issue Aug 18, 2022
4 tasks
@mergify mergify bot mentioned this issue Sep 11, 2022
4 tasks
@mergify mergify bot mentioned this issue Oct 4, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

6 participants