This repository has been archived by the owner on Aug 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[BUG] CI is failing due to wrong diff comparison in Danger #2046
Comments
This was referenced Apr 28, 2020
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 6, 2020
This was referenced May 14, 2020
This was referenced May 22, 2020
Merged
Merged
This was referenced Jul 22, 2022
Closed
This was referenced Oct 11, 2022
This was referenced Oct 19, 2022
This was referenced Dec 30, 2022
This was referenced Jan 9, 2023
This was referenced May 6, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Right now the CI is failing on basically every run because it complains that people removed pixels from others. It appears to be because it's using the wrong diff for the check.
Expected Behavior
PRs like this one should succeed: #2045
Actual Behavior
PR failed because it's claiming it removed additional pixels https://github.com/twilio-labs/open-pixel-art/pull/2045/checks?check_run_id=589878945
Possible Fix
The diff that's being generated by Danger seems to be wrong. I did some digging but couldn't figure out yet how to get the merge commit instead. I asked on Spectrum but haven't heard back yet. Next step would probably be to report a bug on danger/danger-js.
Steps to Reproduce
Context
This is currently blocking the automatic PR experience for users.
The text was updated successfully, but these errors were encountered: