Skip to content
This repository has been archived by the owner on Aug 20, 2023. It is now read-only.

feat(pixels) add my new pixel #2045

Merged
merged 2 commits into from
Apr 22, 2020
Merged

feat(pixels) add my new pixel #2045

merged 2 commits into from
Apr 22, 2020

Conversation

vorpalthunder
Copy link
Contributor

Checklist

  • [ x ] I ran npm test locally and it passed without errors.
  • [ x ] I only edited the _data/pixels.json file.
  • [ x ] I entered the username in the pixels.json that I'm also using to create this pull request.
  • [ x ] I acknowledge that all my contributions will be made under the project's license.

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Unfortunately the automatic code review has failed. Please click the details button for more information. @dkundel

4 similar comments
@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Unfortunately the automatic code review has failed. Please click the details button for more information. @dkundel

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Unfortunately the automatic code review has failed. Please click the details button for more information. @dkundel

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Unfortunately the automatic code review has failed. Please click the details button for more information. @dkundel

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2020

Unfortunately the automatic code review has failed. Please click the details button for more information. @dkundel

@mergify mergify bot added hacktoberfest Hacktoberfest related contributions needs-help labels Apr 15, 2020
@vorpalthunder
Copy link
Contributor Author

@dkundel The CI seems to not be working properly, as when I checked the logs, it said I deleted an entry in the pixels.json file, but it is still here! Any idea how to fix this?

@dkundel
Copy link
Member

dkundel commented Apr 15, 2020

Yeah @polivierstpch I unfortunately noticed but haven't found a solution yet :( I described more of the issue in #2046 and will try to see if I can find a solution this week. But if someone wants to work on that I'd be happy to merge the fix

@dkundel
Copy link
Member

dkundel commented Apr 15, 2020

I'll review the PRs manually later

@dkundel dkundel merged commit 413d10a into twilio-labs:master Apr 22, 2020
@welcome
Copy link

welcome bot commented Apr 22, 2020

Congratulations on your first contribution to the Open Pixel Art project!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

@tesla809
Copy link
Contributor

@dkundel would you be able to review #2158 ?
The CI is failing due to an issue with the danger diff.

See: #2046

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest Hacktoberfest related contributions needs-help
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants