Skip to content
This repository has been archived by the owner on Aug 20, 2023. It is now read-only.

Twilioquest #2053

Merged
merged 6 commits into from
Apr 22, 2020
Merged

Twilioquest #2053

merged 6 commits into from
Apr 22, 2020

Conversation

unaizu
Copy link
Contributor

@unaizu unaizu commented Apr 20, 2020

Checklist

  • I ran npm test locally and it passed without errors.
  • I only edited the _data/pixels.json file.
  • I entered the username in the pixels.json that I'm also using to create this pull request.
  • I acknowledge that all my contributions will be made under the project's license.

@unaizu unaizu closed this Apr 20, 2020
@unaizu unaizu reopened this Apr 20, 2020
@unaizu
Copy link
Contributor Author

unaizu commented Apr 20, 2020

it looks like my pull request failed because the tool is complaining about some other pixels being deleted, I've checked it and the pixels are still there, I've also found #2046 which might be related to my issue, do you know if there is a workaround for it?

Thanks!

@dkundel
Copy link
Member

dkundel commented Apr 22, 2020

Hi @unaizu there's unfortunately no workaround atm :( I have to merge things manually.

@dkundel dkundel merged commit 543f8d3 into twilio-labs:master Apr 22, 2020
@welcome
Copy link

welcome bot commented Apr 22, 2020

Congratulations on your first contribution to the Open Pixel Art project!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

@unaizu unaizu deleted the twilioquest branch May 12, 2020 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants