fix: Add ToString()
override to TwiML class
#672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.
Fixes
Currently, there's a
ToString
method with an optionalSaveOptions formattingOptions
parameter.However, this is not overriding the default
ToString
method that all objects inherit.As a result, in C#, when
TwiML
is cast toobject
, theToString
method will return the name of the class, for exampleTwilio.TwiML.MessagingResponse
. This probably doesn't occur much in the wild.However, in F#, the
Object.ToString()
method will always be used if you don't specify theformattingOptions
argument.Therefor, the
Object.ToString()
method should be overriden insideTwiML
.This PR takes care of that.
Checklist