Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert the commit Use IEnumerable<T> instead of List<T> for TwiML enums via PR (#671) #680

Merged
merged 2 commits into from
May 23, 2023
Merged

fix: revert the commit Use IEnumerable<T> instead of List<T> for TwiML enums via PR (#671) #680

merged 2 commits into from
May 23, 2023

Conversation

AsabuHere
Copy link
Contributor

This reverts commit dbab106.

Fixes

evert the commit Use IEnumerable instead of List for TwiML enums via PR (#671)
A short description of what this PR does.
This PR broke the pipeline, this will be re merged after further investigation

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@AsabuHere
Copy link
Contributor Author

Reverting last two commits since its causing failures in librarian status checks pipeline. These changes will be added again after detailed analysis

shrutiburman
shrutiburman approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock for now.
Please raise a PR to add net60 in targetFramwork & net6.0 as a RuntimeIdentifier, which would solve the pipeline error.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
12.2% 12.2% Duplication

@AsabuHere AsabuHere merged commit f1e1cb0 into main May 23, 2023
@AsabuHere AsabuHere deleted the revert_dotnet_vupdate branch May 23, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman approved these changes

@kridai kridai kridai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsabuHere @kridai @shrutiburman