Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fix for stream not updating when selected input device is null #267

Closed

Conversation

varunm0503
Copy link

@varunm0503 varunm0503 commented May 15, 2024

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR resolves issue #256.
Issue is that audioHelper used to handle updating stream when 'default' device was selected as input device.

However, it is possible that selected input device is empty or null (initially). We should consider this scenario as well as if a default device has been selected. In this case as well, when we get a 'devicechange' event, we should refresh input stream.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

@varunm0503
Copy link
Author

varunm0503 commented May 15, 2024

Logs without fix: twilioWithoutFixLogs.txt
Screenshot 2024-05-15 at 9 18 15 AM

Logs with fix:
twilioLogsWithFixLogs.txt
Screenshot 2024-05-15 at 9 19 38 AM

Please go through the logs. Once you find "Disconnecting bluetooth" log, you can see that setInputDevice is never called after that without the fix applied. With the fix applied, you can find setInputDevice being called

@charliesantos
Copy link
Collaborator

Thanks for submitting @varunm0503 . We'll review and get back to you.

@charliesantos
Copy link
Collaborator

Thanks for your contribution @varunm0503 . I included this in a separate PR along with other fixes #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants