Adds fix for stream not updating when selected input device is null #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR resolves issue #256.
Issue is that audioHelper used to handle updating stream when 'default' device was selected as input device.
However, it is possible that selected input device is empty or null (initially). We should consider this scenario as well as if a default device has been selected. In this case as well, when we get a 'devicechange' event, we should refresh input stream.
Burndown
Before review
npm test
Before merge