VBLOCKS-3054 Fix echo and default stream not switching #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
mhuynh5757
requested changes
May 28, 2024
lib/twilio/audiohelper.ts
Outdated
Comment on lines
837
to
838
| // this.inputDevice is not null if audio.setInputDevice() was explicitly called | ||
| (this.inputDevice && this.inputDevice.deviceId === defaultId) || |
There was a problem hiding this comment.
Nit:
I would prefer to have these complex conditions broken out like so:
const defaultId = 'default';
const isInputDeviceSet = this.inputDevice && this.inputDevice.deviceId === defaultId;
const isInputDeviceNotSet = this._defaultInputDeviceStream && this.availableInputDevices.get(defaultId);
It might not eliminate the need for the comments entirely, but it helps explain things and make the code more readable IMO.
There was a problem hiding this comment.
+1. I'll update it. Though I would rename the 2nd one to isDefaultDeviceSet.
| @@ -1976,6 +1976,23 @@ describe('PeerConnection', () => { | |||
| }).then(done).catch(done); | |||
| }); | |||
|
|
|||
| it('Should call setSinkId with \'\' if empty string is first device', done => { | |||
| output.audio.setSinkId.returns(Promise.resolve()); | |||
There was a problem hiding this comment.
If I'm not mistaken, this will cause the function to return the same promise every time. I don't see it affecting anything in this case, but wanted to note it.
mhuynh5757
approved these changes
May 28, 2024
lib/twilio/audiohelper.ts
Outdated
| // If this.inputDevice is null, and default stream is not null, it means | ||
| // this.inputDevice is not null if audio.setInputDevice() was explicitly called | ||
| const isInputDeviceSet = this.inputDevice && this.inputDevice.deviceId === defaultId; | ||
| // If this.inputDevice is null, and default stream is not null, it means | ||
| // the user is using the default stream and did not explicitly call audio.setInputDevice() |
There was a problem hiding this comment.
Suggested change
| // the user is using the default stream and did not explicitly call audio.setInputDevice() | |
| // the user is using the default stream and did not explicitly call audio.setInputDevice() |
Formatting nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
Please see changelog.
Burndown
Before review
npm testBefore merge