Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 23.11.0 #566

Merged
merged 5 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,12 @@ jobs:
python-version: '3.11'
task:
- name: Check Newsfragment
nox: check_newsfragment
run: |
nox -e check_newsfragment
nox -e draft_newsfragment >> $GITHUB_STEP_SUMMARY
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to see the pending release note rendered

https://github.com/twisted/towncrier/actions/runs/6787483933#summary-18450436014

I hope it can help new contributors understand how the content of newsfragment is used.

In the future, we should have MD... but this is a first step.

run-if: ${{ github.head_ref != 'pre-commit-ci-update-config' }}
- name: Check mypy
nox: typecheck
run: nox -e typecheck
run-if: true

steps:
Expand All @@ -187,7 +189,9 @@ jobs:

- uses: twisted/python-info-action@v1

- run: nox -e ${{ matrix.task.nox }}
- name: Check
run: |
${{ matrix.task.run }}
if: ${{ matrix.task.run-if }}


Expand Down
21 changes: 21 additions & 0 deletions NEWS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,27 @@ Release notes

.. towncrier release notes start

towncrier 23.11.0 (2023-11-08)
==============================

No significant changes since the previous release candidate.


Bugfixes
--------

- ``build`` now treats a missing fragments directory the same as an empty one, consistent with other operations. (`#538 <https://github.com/twisted/towncrier/issues/538>`_)
- Fragments with filenames like `fix-1.2.3.feature` are now associated with the ticket `fix-1.2.3`.
In previous versions they were incorrectly associated to ticket `3`. (`#562 <https://github.com/twisted/towncrier/issues/562>`_)
- Orphan newsfragments containing numeric values are no longer accidentally associated to tickets. In previous versions the orphan marker was ignored and the newsfragment was associated to a ticket having the last numerical value from the filename. (`#562 <https://github.com/twisted/towncrier/issues/562>`_)


Misc
----

- `#558 <https://github.com/twisted/towncrier/issues/558>`_, `#559 <https://github.com/twisted/towncrier/issues/559>`_


towncrier 23.10.0 (2023-10-24)
==============================

Expand Down
6 changes: 6 additions & 0 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ def check_newsfragment(session: nox.Session) -> None:
session.run("python", "-m", "towncrier.check", "--compare-with", "origin/trunk")


@nox.session
def draft_newsfragment(session: nox.Session) -> None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with nox, but I don't realy think we need this and check_newsfragment

but we can keep them for now

session.install(".")
session.run("python", "-m", "towncrier.build", "--draft")


@nox.session
def typecheck(session: nox.Session) -> None:
# Click 8.1.4 is bad type hints -- lets not complicate packaging and only
Expand Down
2 changes: 1 addition & 1 deletion src/towncrier/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# For dev - Version('towncrier', 23, 8, 1, dev=0)
# For RC - Version('towncrier', 23, 9, 0, release_candidate=1)
# For final - Version('towncrier', 23, 9, 0)
__version__ = Version("towncrier", 23, 10, 1, dev=0)
__version__ = Version("towncrier", 23, 11, 1, dev=0)
# The version is exposed in string format to be
# available for the hatching build tools.
_hatchling_version = __version__.short()
Expand Down
1 change: 0 additions & 1 deletion src/towncrier/newsfragments/538.bugfix

This file was deleted.

Empty file.
Empty file.
1 change: 0 additions & 1 deletion src/towncrier/newsfragments/562.bugfix

This file was deleted.

2 changes: 0 additions & 2 deletions src/towncrier/newsfragments/562.bugfix.1

This file was deleted.

Loading