-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 23.11.0 #566
Release 23.11.0 #566
Conversation
for more information, see https://pre-commit.ci
nox: check_newsfragment | ||
run: | | ||
nox -e check_newsfragment | ||
nox -e draft_newsfragment >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to see the pending release note rendered
https://github.com/twisted/towncrier/actions/runs/6787483933#summary-18450436014
I hope it can help new contributors understand how the content of newsfragment is used.
In the future, we should have MD... but this is a first step.
@@ -54,6 +54,12 @@ def check_newsfragment(session: nox.Session) -> None: | |||
session.run("python", "-m", "towncrier.check", "--compare-with", "origin/trunk") | |||
|
|||
|
|||
@nox.session | |||
def draft_newsfragment(session: nox.Session) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with nox, but I don't realy think we need this and check_newsfragment
but we can keep them for now
Release at https://github.com/twisted/towncrier/releases/tag/23.11.0rc1 (via https://pandoc.org/try/) Publish job at https://github.com/twisted/towncrier/actions/runs/6787565610/job/18450749305 PyPi at https://pypi.org/project/towncrier/23.11.0rc1/ this should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. can't really comment on the tooling changes tbh. the idea of having a preview of the changelog is cool!
Thanks for the review. The tool is just a preview ... it look bad in RST. But as part of our "first-class" Markdown support, we can improve it. GitHub Release at https://github.com/twisted/towncrier/releases/tag/23.11.0 GHA job https://github.com/twisted/towncrier/actions/runs/6799591664/job/18486330131 |
Just the release PR
Following the info from https://towncrier.readthedocs.io/en/latest/release.html