Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 23.11.0 #566

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Release 23.11.0 #566

merged 5 commits into from
Nov 8, 2023

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Nov 7, 2023

Just the release PR

Following the info from https://towncrier.readthedocs.io/en/latest/release.html

@adiroiban adiroiban requested a review from a team as a code owner November 7, 2023 16:32
nox: check_newsfragment
run: |
nox -e check_newsfragment
nox -e draft_newsfragment >> $GITHUB_STEP_SUMMARY
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to see the pending release note rendered

https://github.com/twisted/towncrier/actions/runs/6787483933#summary-18450436014

I hope it can help new contributors understand how the content of newsfragment is used.

In the future, we should have MD... but this is a first step.

@@ -54,6 +54,12 @@ def check_newsfragment(session: nox.Session) -> None:
session.run("python", "-m", "towncrier.check", "--compare-with", "origin/trunk")


@nox.session
def draft_newsfragment(session: nox.Session) -> None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with nox, but I don't realy think we need this and check_newsfragment

but we can keep them for now

@adiroiban
Copy link
Member Author

adiroiban commented Nov 7, 2023

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can't really comment on the tooling changes tbh. the idea of having a preview of the changelog is cool!

@adiroiban
Copy link
Member Author

adiroiban commented Nov 8, 2023

Thanks for the review.

The tool is just a preview ... it look bad in RST. But as part of our "first-class" Markdown support, we can improve it.

GitHub Release at https://github.com/twisted/towncrier/releases/tag/23.11.0

GHA job https://github.com/twisted/towncrier/actions/runs/6799591664/job/18486330131

pypi at https://pypi.org/project/Twisted/23.10.0/

@adiroiban adiroiban enabled auto-merge (squash) November 8, 2023 14:33
@adiroiban adiroiban merged commit 4d317bf into trunk Nov 8, 2023
15 checks passed
@adiroiban adiroiban deleted the release-23.11.0 branch November 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants