-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 23.11.0 #566
Merged
Merged
Release 23.11.0 #566
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8b9b4b2
venv/bin/towncrier build --yes
adiroiban 47cf0f3
Show release draft as a step output.
adiroiban bdb1d08
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 503b499
Update final version.
adiroiban 8fb0d8a
Update dev version.
adiroiban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,6 +54,12 @@ def check_newsfragment(session: nox.Session) -> None: | |
session.run("python", "-m", "towncrier.check", "--compare-with", "origin/trunk") | ||
|
||
|
||
@nox.session | ||
def draft_newsfragment(session: nox.Session) -> None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I went with nox, but I don't realy think we need this and check_newsfragment but we can keep them for now |
||
session.install(".") | ||
session.run("python", "-m", "towncrier.build", "--draft") | ||
|
||
|
||
@nox.session | ||
def typecheck(session: nox.Session) -> None: | ||
# Click 8.1.4 is bad type hints -- lets not complicate packaging and only | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Empty file.
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to see the pending release note rendered
https://github.com/twisted/towncrier/actions/runs/6787483933#summary-18450436014
I hope it can help new contributors understand how the content of newsfragment is used.
In the future, we should have MD... but this is a first step.