Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/x] Fix CLI archiving and distribution #260

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

andrewchang-bird
Copy link
Contributor

@andrewchang-bird andrewchang-bird commented Jan 8, 2022

Stack

📚 #266 [6/x] Update example projects to use 0.19.1
📚 #265 [5/x] Fix support for Swift library evolution
📚 #264 [4/x] Fix configurator relative path handling
📚 #263 [3/x] Fix package manager integrations
📚 #261 [2/x] Archive supporting sources in release workflow
📚 #260 ← [1/x] Fix CLI archiving and distribution

Overview

The new automation pipeline uses ZIP Foundation to create archives of the build products. Unfortunately, ZIP Foundation produces malformed CRCs for the mockingbird binary executable (see weichsel/ZIPFoundation#229). This change replaces ZIP Foundation with the Unix zip command and fixes how the Mockingbird.zip archive is inflated by the CLI launcher.

Test Plan

Uploading the binary to staging and pointing the CLI launcher to it works as expected:

% MKB_ARTIFACTS_URL='https://github.com/andrewchang-bird/mockingbird/releases/download/<VERSION>/<FILE>' ./mockingbird version
Using Mockingbird v0.19.0
Downloading Mockingbird from https://github.com/andrewchang-bird/mockingbird/releases/download/0.19.0/Mockingbird.zip into bin/0.19.0
############################################################################################################################################### 100.0%############################################################################################################################################### 100.0%
bin/0.19.0/mockingbird: valid on disk
bin/0.19.0/mockingbird: satisfies its Designated Requirement
bin/0.19.0/mockingbird: explicit requirement satisfied
✅ Verified the code signature
0.19.0

We don’t currently have E2E tests to cover the CLI launcher, but we should add some once 0.19.0 is live. Tracked here: https://github.com/birdrides/mockingbird/projects/2#card-75760097

@andrewchang-bird andrewchang-bird added this to the Release 0.19 milestone Jan 8, 2022
@andrewchang-bird andrewchang-bird changed the title Fix CLI archiving and distribution [1/x] Fix CLI archiving and distribution Jan 8, 2022
andrewchang-bird added a commit that referenced this pull request Jan 8, 2022
The new automation pipeline uses ZIP Foundation to create archives of
the build products. Unfortunately, ZIP Foundation produces malformed
CRCs for the mockingbird binary executable (see
weichsel/ZIPFoundation#229). This change replaces ZIP Foundation with
the Unix zip command and fixes how the Mockingbird.zip archive is
inflated by the CLI launcher.
@andrewchang-bird andrewchang-bird merged commit ab0de2c into master Jan 10, 2022
@andrewchang-bird andrewchang-bird deleted the dev/andrewchang-bird/fix-cli-archive branch January 10, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants