[3/x] Fix package manager integrations #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2022
andrewchang-bird
added a commit
that referenced
this pull request
Jan 8, 2022
Changes to the project structure and build pipeline caused most of the package manager integrations to break. This fixes the regressions and improves the example project tests, allowing them to build against HEAD.
This was referenced Jan 10, 2022
ryanmeisters
approved these changes
Jan 10, 2022
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/archive-supporting-sources
branch
from
1e15f07 to
1b1dbf5
Compare
Base automatically changed from
dev/andrewchang-bird/archive-supporting-sources
to
master
January 10, 2022 20:40
- Move XCFramework to root of archive - Inline MockingbirdCommon with MockingbirdFramework
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-package-managers
branch
from
e90e2d3 to
85ea3ac
Compare
andrewchang-bird
deleted the
dev/andrewchang-bird/fix-package-managers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
📚 #266 [6/x] Update example projects to use 0.19.1
📚 #265 [5/x] Fix support for Swift library evolution
📚 #264 [4/x] Fix configurator relative path handling
📚 #263 ← [3/x] Fix package manager integrations
📚 #261 [2/x] Archive supporting sources in release workflow
📚 #260 [1/x] Fix CLI archiving and distribution
Overview
Changes to the project structure and build pipeline caused most of the package manager integrations to break. The current package manager tests aren’t E2E (they only check if the spec / package definition validates), and the more robust example project tests don’t run against the current revision.
This PR fixes the regressions and improves the example project tests, allowing them to build against HEAD. The goal is to keep the example projects portable such that they can be used as a starting point, so the tests rewrite the Cartfile/Podfile/Package.swift manifest at run time to point to the local repo and CLI build.
Test Plan