[v4] Use prepack and postpack #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
reviewed
Jul 2, 2020
| @@ -191,8 +191,9 @@ module.exports = { | |||
| let pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf-8')); | |||
|
|
|||
| // Really `prepack` and `postpack` would be ideal, but yarn doesn't execute those when publishing | |||
| this._addScript(pkg.scripts, 'prepublishOnly', 'ember ts:precompile'); | |||
| this._addScript(pkg.scripts, 'postpublish', 'ember ts:clean'); | |||
| // As of https://github.com/yarnpkg/yarn/pull/5712 yarn runs `prepack` and `postpack` when publishing | |||
There was a problem hiding this comment.
Do we still need the comment on 193 any more? 🙂
There was a problem hiding this comment.
Oh, lol, I meant to delete it!
jamescdavis
force-pushed
the
use_prepack_and_postpack
branch
from
daf69a9
to
76c730f
Compare
dfreeman
approved these changes
Jul 2, 2020
chriskrycho
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
prepackandpostpackinstead ofprepublishOnlyandpostpublish.As of yarnpkg/yarn#5712
yarnrunsprepackandpostpackwhen publishing (npmalways did).