fix(publish): Run pre and postpack lifecycle scripts on publish #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm runs the pre and post pack scripts on publish, but yarn was not. Added these scripts. fixes yarnpkg#5707
arcanis
requested changes
Apr 23, 2018
| @@ -44,6 +44,7 @@ async function publish(config: Config, pkg: any, flags: Object, dir: string): Pr | |||
| await config.executeLifecycleScript('prepublish'); | |||
| await config.executeLifecycleScript('prepare'); | |||
| await config.executeLifecycleScript('prepublishOnly'); | |||
| await config.executeLifecycleScript('prepack'); | |||
There was a problem hiding this comment.
Shouldn't those lifecycles be part of the pack command rather than publish?
There was a problem hiding this comment.
They already are, but they are in pack's run() function which is not called directly by publish. I considered moving them into the commonly called pack() function, but postpack shouldn't be executed until the output stream is written, so it makes refactoring the scripts to be called in a common spot a bit more complicated. I took the easier route here.
There was a problem hiding this comment.
Makes sense, thanks for the explanation 👍
There was a problem hiding this comment.
Shall we put that explanation in the code as a comment?
arcanis
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
npm runs the pre and post pack scripts on publish, but yarn was not. Added these scripts.
fixes #5707
Test plan
Added a test that regex's the output to look for scripts being run.
If you look at the test, the regex is kinda weird, but I did it that way to make sure the log statements were in the correct order in the output.