Cloud address translation #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-ubskii
force-pushed
the
address-translation
branch
from
af30f94
to
5d5e038
Compare
dmitrii-ubskii
commented
Apr 17, 2024
Comment on lines
-99
to
+88
| colorJsonKey("address: ") + replica.address() + ";" + | ||
| colorJsonKey(" server: ") + replica.server() + ";" + |
There was a problem hiding this comment.
Updated to reflect changes in driver
Comment on lines
-501
to
+492
| TypeDBDriver driver = null; | ||
| try { | ||
| TypeDBDriver driver; |
There was a problem hiding this comment.
In this version, driver is never null
Comment on lines
515
to
517
| System.exit(1); | ||
| return null; // unreachable, but needed to satisfy the compiler | ||
| } |
There was a problem hiding this comment.
Java compiler doesn't understand that System.exit() diverges.
Comment on lines
-505
to
-507
| } else { | ||
| String optCloud = options.cloud(); | ||
| if (optCloud != null) { |
Comment on lines
+868
to
+871
| split = "," | ||
| ) | ||
| private @Nullable | ||
| String cloud; | ||
| String[] cloud; |
There was a problem hiding this comment.
picocli treats --cloud=1,2,3 --cloud=4 as [1, 2, 3, 4] with these settings.
flyingsilverfin
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
We allow connection to the cloud servers using an address translation mapping (cf. typedb/typedb-driver#624). This is useful when the route from the user to the servers differs from the route the servers are configured with (e.g. connection to public-facing servers from an internal network).
Example usage:
console \ --cloud=typedb1.domain.com:1729=typedb.local:11729,typedb2.domain.com:1729=typedb.local:21729 \ --username=<user> --password=<password>or:
console \ --cloud=typedb1.domain.com:1729=typedb.local:11729 \ --cloud=typedb2.domain.com:1729=typedb.local:21729 \ --username=<user> --password=<password>Note: we currently require that the user provides translation for the addresses of all nodes in the Cloud deployment.
Implementation
We also update the license headers and file from AGPL to MPL 2.0.