Address translation #624
Merged
Address translation #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
dmitrii-ubskii
force-pushed
the
address-mapping
branch
4 times, most recently
from
d23e2dd
to
af35581
Compare
dmitrii-ubskii
commented
Apr 4, 2024
…sed addresses as names" This reverts commit f6f4c6f.
dmitrii-ubskii
force-pushed
the
address-mapping
branch
from
53b1f9c
to
ecd277d
Compare
dmitrii-ubskii
commented
Apr 11, 2024
Comment on lines
-275
to
+276
| test-python-integration-core: | ||
| test-python-integration: |
There was a problem hiding this comment.
Unified integration tests across languages.
Comment on lines
-86
to
+89
| * @param addresses The address(es) of the TypeDB server(s) | ||
| * @param addresses The address(es) of the TypeDB server(s) or translation map from addresses | ||
| * received from the TypeDB server(s) to addresses to be used by the driver for connection |
There was a problem hiding this comment.
Constructor overloads don't seem to get separate docs generated.
Comment on lines
-33
to
+34
| Driver Driver::coreDriver(const std::string& coreAddress) { | ||
| auto p = _native::connection_open_core(coreAddress.c_str()); | ||
| Driver Driver::coreDriver(const std::string& address) { | ||
| auto p = _native::connection_open_core(address.c_str()); |
There was a problem hiding this comment.
Bring in line with declaration.
Comment on lines
-73
to
+74
| * @param addresses The address(es) of the TypeDB server(s) | ||
| * @param addresses The address(es) of the TypeDB server(s) or translation map from addresses | ||
| * received from the TypeDB server(s) to addresses to be used by the driver for connection |
There was a problem hiding this comment.
Same as C++, separate docs for overloaded ctors aren't generated.
Comment on lines
+81
to
+82
| elif isinstance(addresses, Mapping): | ||
| return _Driver(dict(addresses), credential) |
There was a problem hiding this comment.
A Mapping is an Iterable, but not vice versa, so this check must come first.
flyingsilverfin
approved these changes
Apr 11, 2024
dmitrii-ubskii
added a commit
to typedb/typedb-console
that referenced
this pull request
Apr 17, 2024
## Usage and product changes We allow connection to the cloud servers using an address translation mapping (cf. typedb/typedb-driver#624). This is useful when the route from the user to the servers differs from the route the servers are configured with (e.g. connection to public-facing servers from an internal network). Example usage: ```bash console \ --cloud=typedb1.domain.com:1729=typedb.local:11729,typedb2.domain.com:1729=typedb.local:21729 \ --username=<user> --password=<password> ``` or: ```bash console \ --cloud=typedb1.domain.com:1729=typedb.local:11729 \ --cloud=typedb2.domain.com:1729=typedb.local:21729 \ --username=<user> --password=<password> ``` Note: we currently require that the user provides translation for the addresses of _all_ nodes in the Cloud deployment. ## Implementation We also update the license headers and file from AGPL to MPL 2.0.
typedb-bot
pushed a commit
to typedb/typedb-studio
that referenced
this pull request
May 7, 2024
## Usage and product changes We introduce a way to provide address translation when attempting to connect to cloud servers (cf. typedb/typedb-driver#624). This is useful when the route from the user to the servers differs from the route the servers are configured with (e.g. connection to public-facing servers from an internal network). Note: we currently require that the user provides translation for the addresses of _all_ nodes in the Cloud deployment. <img width="532" src="https://github.com/vaticle/typedb-studio/assets/18616863/74859fbd-de4f-4844-b1e6-f3507dc364b7">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
We allow the user to provide a translation map from the advertised server addresses (now treated as generic server names) to the actual addresses the driver shall use to connect to the cloud instances. We require the user to provide the full mapping.
Example usage:
Python:
Rust: