Cloud address translation #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-ubskii
force-pushed
the
address-translation
branch
2 times, most recently
from
3c3da9e
to
fab7a5d
Compare
dmitrii-ubskii
force-pushed
the
address-translation
branch
from
fab7a5d
to
bbd857b
Compare
dmitrii-ubskii
commented
May 3, 2024
Comment on lines
-35
to
+45
| override fun cancel() = Service.driver.updateDefaultPasswordDialog.cancel() | ||
| override fun submit() = Service.driver.updateDefaultPasswordDialog.submit(oldPassword, newPassword) | ||
| override fun cancel() { | ||
| Service.driver.updateDefaultPasswordDialog.cancel() | ||
| oldPassword = "" | ||
| newPassword = "" | ||
| } | ||
| override fun submit() { | ||
| assert(isValid()) | ||
| Service.driver.updateDefaultPasswordDialog.submit(oldPassword, newPassword) | ||
| oldPassword = "" | ||
| newPassword = "" | ||
| } |
There was a problem hiding this comment.
Drive-by: discard password field contents on submit / cancel.
dmitrii-ubskii
requested review from
alexjpwalker and
flyingsilverfin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
We introduce a way to provide address translation when attempting to connect to cloud servers (cf. typedb/typedb-driver#624). This is useful when the route from the user to the servers differs from the route the servers are configured with (e.g. connection to public-facing servers from an internal network).
Note: we currently require that the user provides translation for the addresses of all nodes in the Cloud deployment.