Introduce Values to support expressions #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnangovindraj
requested review from
alexjpwalker and
haikalpribadi
as code owners
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
|
Tests are red because the cluster artifact doesn't support arithmetic. |
| @Override | ||
| public Concept.Remote asRemote(TypeDBTransaction transaction) { | ||
| throw new TypeDBClientException(VALUECONCEPT_HAS_NO_REMOTE); | ||
| } |
There was a problem hiding this comment.
Value concepts are ephemeral and have no remote.
krishnangovindraj
changed the title
flyingsilverfin
force-pushed
the
arithmetic-add-value-concept
branch
2 times, most recently
from
6ecf2eb
to
64456a3
Compare
flyingsilverfin
approved these changes
May 23, 2023
flyingsilverfin
changed the title
flyingsilverfin
changed the title
alexjpwalker
approved these changes
May 25, 2023
flyingsilverfin
changed the title
flyingsilverfin
changed the title
dmitrii-ubskii
added a commit
that referenced
this pull request
Aug 22, 2023
## What is the goal of this PR? We update the Rust driver to support the features introduced in driver Java since v2.19 in effort to preserve the feature set when transitioning from the JVM-native implementation to the Rust JNI implementation. ## What are the changes implemented in this PR? Changes in master since branching (#417): Reimplemented in Rust and made available in Java over JNI: - #409 - #421 - 1f396a6 Improve method unavailable error message - #430 - #431: partial, since `tonic` does not report SSL errors to the same granularity Cherry-picked directly: - #415 - 42800e7 Update VERSION to 2.18.1 - 7cd0a5a Add eclipsesource-minimal-json to maven dependencies (#423) - 63614ec Update CODEOWNERS - #424 Dropped entirely (Java-specific or obsolete): - #422 - 8c0caa1 Update VERSION and release notes --------- Co-authored-by: Benjamin Small <benjaminasmall@gmail.com> Co-authored-by: joshua <joshua@vaticle.com> Co-authored-by: Krishnan Govindraj <krishnangovindraj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Introduce the 'Value' type, which is returned as the result of an expression's computation. This change follows from typedb/typeql#260, which outlines the capabilities of the new expression syntax.
Values (representing any of Long, Double, Boolean, String, or DateTime) are returned as part of
ConceptMapanswers and are subtypes ofConceptfor the time being. Their main API is made of the.getValue()method and.getValueType()method, along with all the standard safe downcasting methods to convert aConceptinto aValue, usingConcept.isValue()andConcept.asValue().We also move the import location of
ValueTypefrom being nested inAttributeTypetoConcept.What are the changes implemented in this PR?
Valueconcept and the requiredValueImplthat implements itValueTypeto no longer live withinAttributeType- now it exists inConcept.ValueTypeExpressionTestbehaviour scenarios, which we also add to CI